From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: minor __alloc_skb() optimization
Date: Tue, 13 Jan 2026 17:44:17 -0800 [thread overview]
Message-ID: <20260113174417.32b13cc1@kernel.org> (raw)
In-Reply-To: <20260113131017.2310584-1-edumazet@google.com>
On Tue, 13 Jan 2026 13:10:17 +0000 Eric Dumazet wrote:
> We can directly call __finalize_skb_around()
> instead of __build_skb_around() because @size is not zero.
FWIW I've been tempted to delete the zero check from
__build_skb_around() completely recently..
It's been a few years since we added slab_build_skb()
surely any buggy driver that's actually used would have
already hit that WARN_ONCE() and gotten reported?
next prev parent reply other threads:[~2026-01-14 1:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 13:10 [PATCH net-next] net: minor __alloc_skb() optimization Eric Dumazet
2026-01-14 1:44 ` Jakub Kicinski [this message]
2026-01-14 1:54 ` Eric Dumazet
2026-01-14 2:01 ` Eric Dumazet
2026-01-14 2:30 ` Jakub Kicinski
2026-01-16 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113174417.32b13cc1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox