public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org,
	Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Subject: [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying
Date: Tue, 13 Jan 2026 20:38:15 +0100	[thread overview]
Message-ID: <20260113193817.582-1-dawid.osuchowski@linux.intel.com> (raw)

The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.

According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.

Instead of relying on the caller of ice_aq_sff_eeprom() to implement
retrying, use the existing retry infrastructure in ice_sq_send_cmd_retry()
to always attempt retry on receiving EBUSY.

Reproduction steps
------------------
	# ethtool -m <interface_name>
	netlink error: Input/output error

Link: https://www.intel.com/content/www/us/en/content-details/613875/intel-ethernet-controller-e810-datasheet.html [1]

Jakub Staniszewski (2):
  ice: reintroduce retry mechanism for indirect AQ
  ice: fix retry for AQ command 0x06EE

 drivers/net/ethernet/intel/ice/ice_common.c  | 13 ++++++--
 drivers/net/ethernet/intel/ice/ice_ethtool.c | 35 ++++++++------------
 2 files changed, 24 insertions(+), 24 deletions(-)


base-commit: 855e576f30278714c7ca067005f46807aca2e6d4
-- 
2.51.0


             reply	other threads:[~2026-01-13 19:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 19:38 Dawid Osuchowski [this message]
2026-01-13 19:38 ` [PATCH iwl-net 1/2] ice: reintroduce retry mechanism for indirect AQ Dawid Osuchowski
2026-01-13 22:31   ` [Intel-wired-lan] " Paul Menzel
2026-01-14  8:15     ` Dawid Osuchowski
2026-02-27  6:05   ` Rinitha, SX
2026-01-13 19:38 ` [PATCH iwl-net 2/2] ice: fix retry for AQ command 0x06EE Dawid Osuchowski
2026-01-14  9:16   ` [Intel-wired-lan] " Paul Menzel
2026-02-27  6:06   ` Rinitha, SX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113193817.582-1-dawid.osuchowski@linux.intel.com \
    --to=dawid.osuchowski@linux.intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox