public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: dsa: mt7530: Allow interrupts-extended dependency
@ 2026-01-13 11:00 AngeloGioacchino Del Regno
  2026-01-13 22:30 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-13 11:00 UTC (permalink / raw)
  To: devicetree
  Cc: andrew, olteanv, davem, edumazet, kuba, pabeni, robh, krzk+dt,
	conor+dt, matthias.bgg, angelogioacchino.delregno, arinc.unal,
	Landen.Chao, dqfext, sean.wang, daniel, netdev, linux-kernel,
	linux-arm-kernel, linux-mediatek, kernel

When the MT7530 switch is configured as an interrupt-controller it
also needs an interrupt but, in this case, only "interrupts" was
allowed.

Some devicetrees instead use the interrupts-extended property as a
shorter form, and in place of "interrupts" and "interrupt-parent",
as an equivalent.

For this reason, when interrupt-controller is present, depend on
either `interrupts` or `interrupts-extended`; this also resolves
some dtbs_check warnings.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index 815a90808901..ffeb8d5836fe 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
@@ -279,8 +279,11 @@ allOf:
         - resets
         - reset-names
 
-  - dependencies:
-      interrupt-controller: [ interrupts ]
+  - anyOf:
+      - dependencies:
+          interrupt-controller: [ interrupts ]
+      - dependencies:
+          interrupt-controller: [ interrupts-extended ]
 
   - if:
       properties:
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: net: dsa: mt7530: Allow interrupts-extended dependency
  2026-01-13 11:00 [PATCH] dt-bindings: net: dsa: mt7530: Allow interrupts-extended dependency AngeloGioacchino Del Regno
@ 2026-01-13 22:30 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2026-01-13 22:30 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: devicetree, andrew, olteanv, davem, edumazet, kuba, pabeni,
	krzk+dt, conor+dt, matthias.bgg, arinc.unal, Landen.Chao, dqfext,
	sean.wang, daniel, netdev, linux-kernel, linux-arm-kernel,
	linux-mediatek, kernel

On Tue, Jan 13, 2026 at 12:00:20PM +0100, AngeloGioacchino Del Regno wrote:
> When the MT7530 switch is configured as an interrupt-controller it
> also needs an interrupt but, in this case, only "interrupts" was
> allowed.
> 
> Some devicetrees instead use the interrupts-extended property as a
> shorter form, and in place of "interrupts" and "interrupt-parent",
> as an equivalent.
> 
> For this reason, when interrupt-controller is present, depend on
> either `interrupts` or `interrupts-extended`; this also resolves
> some dtbs_check warnings.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml       | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index 815a90808901..ffeb8d5836fe 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -279,8 +279,11 @@ allOf:
>          - resets
>          - reset-names
>  
> -  - dependencies:
> -      interrupt-controller: [ interrupts ]
> +  - anyOf:
> +      - dependencies:
> +          interrupt-controller: [ interrupts ]
> +      - dependencies:
> +          interrupt-controller: [ interrupts-extended ]

We already fixup this case:

dependencies:
  interrupts: ...

And there's a few other cases like yours. So I've pushed a dtschema 
change to handle this case.

Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-13 22:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-13 11:00 [PATCH] dt-bindings: net: dsa: mt7530: Allow interrupts-extended dependency AngeloGioacchino Del Regno
2026-01-13 22:30 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox