public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	conor+dt@kernel.org, krzk+dt@kernel.org, pabeni@redhat.com,
	kuba@kernel.org, edumazet@google.com, davem@davemloft.net,
	andrew+netdev@lunn.ch
Subject: Re: [PATCH net-next v1] dt-bindings: net: Convert icplus-ip101ag to yaml format
Date: Tue, 13 Jan 2026 17:12:22 -0600	[thread overview]
Message-ID: <20260113231222.GA421230-robh@kernel.org> (raw)
In-Reply-To: <20260110235544.1593197-1-martin.blumenstingl@googlemail.com>

On Sun, Jan 11, 2026 at 12:55:44AM +0100, Martin Blumenstingl wrote:
> This allows for better validation of .dts.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  .../bindings/net/icplus,ip101ag.yaml          | 75 +++++++++++++++++++
>  .../bindings/net/icplus-ip101ag.txt           | 19 -----
>  2 files changed, 75 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/icplus,ip101ag.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/icplus-ip101ag.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/icplus,ip101ag.yaml b/Documentation/devicetree/bindings/net/icplus,ip101ag.yaml
> new file mode 100644
> index 000000000000..f245516103b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/icplus,ip101ag.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/icplus,ip101ag.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IC Plus Corp. IP101A / IP101G Ethernet PHYs
> +
> +maintainers:
> +  - Andrew Lunn <andrew@lunn.ch>
> +  - Florian Fainelli <f.fainelli@gmail.com>
> +  - Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> +
> +description: |
> +  Bindings for IC Plus Corp. IP101A / IP101G Ethernet MII/RMII PHYs

Drop 'Bindings for'

> +
> +  There are different models of the IP101G Ethernet PHY:
> +  - IP101GR (32-pin QFN package)
> +  - IP101G (die only, no package)
> +  - IP101GA (48-pin LQFP package)
> +
> +  There are different models of the IP101A Ethernet PHY (which is the
> +  predecessor of the IP101G):
> +  - IP101A (48-pin LQFP package)
> +  - IP101AH (48-pin LQFP package)
> +
> +  All of them share the same PHY ID.
> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  compatible:
> +    contains:

Drop contains. The list(s) of allowed values should be exact.

> +      enum:
> +        - ethernet-phy-id0243.0c54
> +
> +  icplus,select-rx-error:
> +    type: boolean
> +    description: |
> +      Pin 21 ("RXER/INTR_32") will output the receive error status.
> +      Interrupts are not routed outside the PHY in this mode.
> +
> +      This is only supported for IP101GR (32-pin QFN package).
> +
> +  icplus,select-interrupt:
> +    type: boolean
> +    description: |
> +      Pin 21 ("RXER/INTR_32") will output the interrupt signal.
> +
> +      This is only supported for IP101GR (32-pin QFN package).
> +
> +# RXER and INTR_32 functions are mutually exclusive
> +dependentSchemas:
> +  icplus,select-rx-error:
> +    properties:
> +      icplus,select-interrupt: false
> +  icplus,select-interrupt:
> +    properties:
> +      icplus,select-rx-error: false
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethphy1: ethernet-phy@1 {
> +                compatible = "ethernet-phy-id0243.0c54";
> +                reg = <1>;
> +                icplus,select-interrupt;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/net/icplus-ip101ag.txt b/Documentation/devicetree/bindings/net/icplus-ip101ag.txt
> deleted file mode 100644
> index a784592bbb15..000000000000
> --- a/Documentation/devicetree/bindings/net/icplus-ip101ag.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -IC Plus Corp. IP101A / IP101G Ethernet PHYs
> -
> -There are different models of the IP101G Ethernet PHY:
> -- IP101GR (32-pin QFN package)
> -- IP101G (die only, no package)
> -- IP101GA (48-pin LQFP package)
> -
> -There are different models of the IP101A Ethernet PHY (which is the
> -predecessor of the IP101G):
> -- IP101A (48-pin LQFP package)
> -- IP101AH (48-pin LQFP package)
> -
> -Optional properties for the IP101GR (32-pin QFN package):
> -
> -- icplus,select-rx-error:
> -  pin 21 ("RXER/INTR_32") will output the receive error status.
> -  interrupts are not routed outside the PHY in this mode.
> -- icplus,select-interrupt:
> -  pin 21 ("RXER/INTR_32") will output the interrupt signal.
> -- 
> 2.52.0
> 

      reply	other threads:[~2026-01-13 23:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10 23:55 [PATCH net-next v1] dt-bindings: net: Convert icplus-ip101ag to yaml format Martin Blumenstingl
2026-01-13 23:12 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113231222.GA421230-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox