Netdev List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	netdev@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: airoha: npu: Add EN7581-7996 support
Date: Wed, 14 Jan 2026 09:35:42 +0100	[thread overview]
Message-ID: <20260114-heretic-optimal-seahorse-bb094d@quoll> (raw)
In-Reply-To: <20260113-airoha-npu-firmware-name-v2-1-28cb3d230206@kernel.org>

On Tue, Jan 13, 2026 at 09:20:27AM +0100, Lorenzo Bianconi wrote:
> Introduce en7581-npu-7996 compatible string in order to enable MT76 NPU
> offloading for MT7996 (Eagle) chipset since it requires different
> binaries with respect to the ones used for MT7992 on the EN7581 SoC.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> index 59c57f58116b568092446e6cfb7b6bd3f4f47b82..96b2525527c14f60754885c1362b9603349a6353 100644
> --- a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> @@ -18,6 +18,7 @@ properties:
>    compatible:
>      enum:
>        - airoha,en7581-npu
> +      - airoha,en7581-npu-7996

This does not warrant new compatible. There is some misunderstanding and
previous discussion asked you to use proper compatible, not invent fake
one for non-existing hardware.  Either you have en7996-npu or
en7581-npu. Not some mixture.


Best regards,
Krzysztof


  reply	other threads:[~2026-01-14  8:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  8:20 [PATCH net-next v2 0/2] airoha: Add the en7581-npu-7996 support Lorenzo Bianconi
2026-01-13  8:20 ` [PATCH net-next v2 1/2] dt-bindings: net: airoha: npu: Add EN7581-7996 support Lorenzo Bianconi
2026-01-14  8:35   ` Krzysztof Kozlowski [this message]
2026-01-14  9:01     ` Lorenzo Bianconi
2026-01-14  9:26       ` Krzysztof Kozlowski
2026-01-14 10:09         ` Christian Marangi
2026-01-14 10:34           ` Krzysztof Kozlowski
2026-01-14 10:39             ` Christian Marangi
2026-01-14 15:56               ` Andrew Lunn
2026-01-14 16:29                 ` Christian Marangi
2026-01-14 17:47                   ` Andrew Lunn
2026-01-14 18:16                     ` Lorenzo Bianconi
2026-01-14 20:15                       ` Andrew Lunn
2026-01-14 22:35                         ` Lorenzo Bianconi
2026-01-15 17:50                           ` Andrew Lunn
2026-01-16  9:10                             ` Lorenzo Bianconi
2026-01-17 17:53                               ` Lorenzo Bianconi
2026-01-17 19:27                                 ` Benjamin Larsson
2026-01-17 22:18                                 ` Andrew Lunn
2026-01-18  0:02                                   ` Benjamin Larsson
2026-01-19 11:07                                   ` Lorenzo Bianconi
2026-01-19 12:03                                     ` Christian Marangi
2026-01-19 14:04                                     ` Andrew Lunn
2026-01-14 10:39             ` Lorenzo Bianconi
2026-01-13  8:20 ` [PATCH net-next v2 2/2] net: airoha: npu: Add en7581-npu-7996 compatible string Lorenzo Bianconi
2026-01-14  0:32   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114-heretic-optimal-seahorse-bb094d@quoll \
    --to=krzk@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox