From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C42D332AAD4 for ; Wed, 14 Jan 2026 19:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768417380; cv=none; b=D8i4tcJEpAxN5knBHWKrvfz9MCCjcVC6rGRnx/qP15JZGPviXPovqksLhN5bUrQYG3Q9ol89m1k88NZM2y+3ER5bIlYFa1Bp3MpETZHN8SLXd5SznOl1tgZvFp9axdHay8f5KAfhfJgUlzvGJjwflwKHvJv1+Uk9rEBDv1NXg8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768417380; c=relaxed/simple; bh=dM8WzcBwVGKmj0SltOmlTIrgVx4XI4wR6LCK9i1T7Zg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oCjjSDVA3nLpDBnj+Hx5FLIVPqRoM9t9RxwCF1kNQhGWaTnflrp8vyiN53pfQkXC3Zg89heAVRJ9y72Ia5FeF0Ae+kGkVqI5QgWP3fYmMkFX8N/fY8IxIK1CcK116+6cwmQ2Le4jgfXLPy5ty+0I+x0O/a5dUnEzWpoBM7yITWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hXGeSfxY; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hXGeSfxY" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-64b9cb95009so13528a12.1 for ; Wed, 14 Jan 2026 11:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768417377; x=1769022177; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zqOxMcid/peC1Iie6lTLw8C1UUftl4S8ZikbVgEoS64=; b=hXGeSfxYvNTYCGReSXPE9b9PjCuDj1VBcDNy2XxSceLUtDARcEsOsbGA2UBPl99EQK CNNZ7qbPbN08KAdjt+qAuT48BScnz4eVzeo64dce/B2QOFOr3wv6YDM+aY72eBFk2AP/ Ias9D1lRmxP1kz2BCm+/pvlgur4DVtzMckN15++6Mps8zE20upY4K1jJznafoEoo9Y4u 1hwPqIroWzijNmnaRh8TaZLa+59VSWerrIl5y0+DTXBZjm+fli81REIkKg8MigUf5v0I EEu041ayIRLgePoIlJ4r5MWCGveLrkqErhIvFtRnL+A6sgisyRymHW9dPKHYyBY+36Zk /0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768417377; x=1769022177; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqOxMcid/peC1Iie6lTLw8C1UUftl4S8ZikbVgEoS64=; b=G+e2Uk95pwUEjSCxTWDwD0yLdisi9KgPnNAJSIz5yvoBZelQ+39VgSwxaZ7WuQac8z soFhfhlr7k6HAbHUJfOOXyEdCP369Jm4G5virQ8xKXVR76bD3rtTXOMmG0txq/xxxo5P UCl/HtmarLdfmJ/NJll9A+ch2izDgvcq3XfPf5Nxi4SFtYyWPR1uOi+zWlG5k0npJ258 70MnOigIn+b511OIGiL0aj+8z3K08XZuLVr7ocFAc3bFA8OkIIhEAHPavC13M1AqhEiI FCFyIeEtXgpzDXM/+a5K54fol8SbmSr1TmZJOSk6l4nGId00AyfdBZtHj1bx3f+SGeI+ 0CvQ== X-Forwarded-Encrypted: i=1; AJvYcCWc+5TelqMMROjF4vQgjjGWPlAKtyUzxyjg/+S6DTqlaNxogNXXjIsdxTT2y33HHGHo/iL6XdA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl56rODBaPIVEv7Z3sHBwHFtgkI5Mry1uwQxPFE1kpXA1oDnQh Etz+0hk+NY7mEmFnnKcDCR2JwZgxQzt7sUpVcxx9qwgXGy8RmtYDsHPZ X-Gm-Gg: AY/fxX6cxlOxP5DWdVk6UzDSYrppgkDSImcmZxVxU+hPMAV4y0eikQkkCF+9cLfranT 92QpvpY+qWxuAybJnIWA3iC0TO7x/xmQP6vsCC/VaaPUBtYte5hrg0GZNzhb1x000LAX5jkI5LO rKDWScMZhFrTyoWUjp3QNSynShq33OFs10XFcLDQNiXlbg1UVVXKCTSXhC1E2HipHSIUSNhEhTm Vd3VCXvcwCWKBQF7mYgEqbJfA+kHStXYcU0cUul9OMEM+vbwjEQn4J6WXD5RBD9GP1HeIKilMcM wABCVcVSFya7dgUNEsncufdvmAXPHmSXRBixSHWpnTVMsZUscEpOwia4r1IMLJ66bARSheW8hN5 V/OzvVTfOLz41QIE9yvNbSS7cbfuJMjOewM+25VNKjU5jFfakOvyQ3zkU5L+l8WJsWlhgPKhSc/ hfFtg= X-Received: by 2002:a05:6402:34d3:b0:64b:5a76:792b with SMTP id 4fb4d7f45d1cf-653ec459a3cmr1649376a12.3.1768417377014; Wed, 14 Jan 2026 11:02:57 -0800 (PST) Received: from skbuf ([2a02:2f04:d703:5400:9b39:8144:8a26:667e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65411877591sm391335a12.5.2026.01.14.11.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 11:02:56 -0800 (PST) Date: Wed, 14 Jan 2026 21:02:53 +0200 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next 03/14] phy: qcom-sgmii-eth: add .set_mode() and .validate() methods Message-ID: <20260114190253.ttrookxubevt7aku@skbuf> References: <20260114184705.djvad5phrnfen6wx@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 14, 2026 at 06:55:34PM +0000, Russell King (Oracle) wrote: > On Wed, Jan 14, 2026 at 08:47:05PM +0200, Vladimir Oltean wrote: > > On Wed, Jan 14, 2026 at 05:45:24PM +0000, Russell King (Oracle) wrote: > > > qcom-sgmii-eth is an Ethernet SerDes supporting only Ethernet mode > > > using SGMII, 1000BASE-X and 2500BASE-X. > > > > > > Add an implementation of the .set_mode() method, which can be used > > > instead of or as well as the .set_speed() method. The Ethernet > > > interface modes mentioned above all have a fixed data rate, so > > > setting the mode is sufficient to fully specify the operating > > > parameters. > > > > > > Add an implementation of the .validate() method, which will be > > > necessary to allow discovery of the SerDes capabilities for platform > > > independent SerDes support in the stmmac netowrk driver. > > > > s/netowrk/network/ > > > > > > > > Signed-off-by: Russell King (Oracle) > > > --- > > > > Reviewed-by: Vladimir Oltean > > According to patchwork (I forgot the RFC tag on the patches) it needs > linux/phy.h included. Plesae let me know if you'd like me to retain > your r-b. Thanks. Ah, ok, I thought that the SPEED_* macros are also phylib-specific like PHY_INTERFACE_MODE_*, and hence, the phylib header would already be included, but it seems the SPEED_* macros are provided by include/uapi/linux/ethtool.h. Go figure... Please keep the review tag.