From: Jakub Kicinski <kuba@kernel.org>
To: Tao Wang <tao03.wang@horizon.auto>
Cc: <alexandre.torgue@foss.st.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<maxime.chevallier@bootlin.com>, <mcoquelin.stm32@gmail.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after resume
Date: Wed, 14 Jan 2026 19:16:45 -0800 [thread overview]
Message-ID: <20260114191645.03ed8d67@kernel.org> (raw)
In-Reply-To: <20260114110031.113367-1-tao03.wang@horizon.auto>
On Wed, 14 Jan 2026 19:00:31 +0800 Tao Wang wrote:
> To solve the issue, set last_segment to false in stmmac_free_tx_buffer:
> tx_q->tx_skbuff_dma[i].last_segment = false. Do not use the last_segment
> default value and set last_segment to false in stmmac_tso_xmit. This
> will prevent similar issues from occurring in the future.
>
> Fixes: c2837423cb54 ("net: stmmac: Rework TX Coalesce logic")
>
> changelog:
> v1 -> v2:
> - Modify commit message, del empty line, add fixed commit
> information.
>
> Signed-off-by: Tao Wang <tao03.wang@horizon.auto>
When you repost to address Russell's feedback in the commit
message please:
- follow the recommended format (changelog placement and no empty
lines between Fixes and SoB):
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
- do not send new version in reply to the old one, start a new thread
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-15 3:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 7:02 [PATCH net Resend] net: stmmac: fix transmit queue timed out after resume Tao Wang
2026-01-13 4:05 ` Jakub Kicinski
2026-01-14 11:00 ` [PATCH net v2] " Tao Wang
2026-01-14 11:26 ` Russell King (Oracle)
2026-01-15 7:08 ` Tao Wang
2026-01-15 12:09 ` Russell King (Oracle)
2026-01-15 19:40 ` Russell King (Oracle)
2026-01-15 21:04 ` Maxime Chevallier
2026-01-15 21:35 ` Maxime Chevallier
2026-01-16 0:50 ` Russell King (Oracle)
2026-01-16 13:37 ` Russell King (Oracle)
2026-01-16 18:08 ` Russell King (Oracle)
2026-01-16 18:27 ` Maxime Chevallier
2026-01-16 19:22 ` Russell King (Oracle)
2026-01-16 20:57 ` Russell King (Oracle)
2026-01-17 17:06 ` Jakub Kicinski
2026-01-17 20:50 ` Russell King (Oracle)
2026-01-16 7:29 ` Tao Wang
2026-01-15 3:16 ` Jakub Kicinski [this message]
2026-01-15 7:19 ` Tao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114191645.03ed8d67@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tao03.wang@horizon.auto \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox