public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: netdev@vger.kernel.org
Cc: alexanderduyck@fb.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, horms@kernel.org,
	jacob.e.keller@intel.com, kernel-team@meta.com, kuba@kernel.org,
	lee@trager.us, mohsin.bashr@gmail.com, pabeni@redhat.com,
	sanman.p211993@gmail.com
Subject: [PATCH net-next V2 1/5] eth: fbnic: Use GFP_KERNEL to allocting mbx pages
Date: Wed, 14 Jan 2026 16:33:49 -0800	[thread overview]
Message-ID: <20260115003353.4150771-2-mohsin.bashr@gmail.com> (raw)
In-Reply-To: <20260115003353.4150771-1-mohsin.bashr@gmail.com>

Replace GFP_ATOMIC with GFP_KERNEL for mailbox RX page allocation. Since
interrupt handler is threaded GFP_KERNEL is a safe option to reduce
allocation failures.

Also remove __GFP_NOWARN so the kernel reports a warning on allocation
failure to aid debugging.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
 drivers/net/ethernet/meta/fbnic/fbnic_fw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
index d8d9b6cfde82..3dfd3f2442ff 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
@@ -205,8 +205,7 @@ static int fbnic_mbx_alloc_rx_msgs(struct fbnic_dev *fbd)
 	while (!err && count--) {
 		struct fbnic_tlv_msg *msg;
 
-		msg = (struct fbnic_tlv_msg *)__get_free_page(GFP_ATOMIC |
-							      __GFP_NOWARN);
+		msg = (struct fbnic_tlv_msg *)__get_free_page(GFP_KERNEL);
 		if (!msg) {
 			err = -ENOMEM;
 			break;
-- 
2.47.3


  reply	other threads:[~2026-01-15  0:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  0:33 [PATCH net-next V2 0/5] eth: fbnic: Update IPC mailbox support Mohsin Bashir
2026-01-15  0:33 ` Mohsin Bashir [this message]
2026-01-15  0:33 ` [PATCH net-next V2 2/5] eth: fbnic: Allocate all pages for RX mailbox Mohsin Bashir
2026-01-15  0:33 ` [PATCH net-next V2 3/5] eth: fbnic: Reuse RX mailbox pages Mohsin Bashir
2026-01-15  0:33 ` [PATCH net-next V2 4/5] eth: fbnic: Remove retry support Mohsin Bashir
2026-01-15  0:33 ` [PATCH net-next V2 5/5] eth: fbnic: Update RX mbox timeout value Mohsin Bashir
2026-01-20 10:04   ` Paolo Abeni
2026-01-20 21:43     ` Mohsin Bashir
2026-01-21  2:30 ` [PATCH net-next V2 0/5] eth: fbnic: Update IPC mailbox support patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115003353.4150771-2-mohsin.bashr@gmail.com \
    --to=mohsin.bashr@gmail.com \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=lee@trager.us \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sanman.p211993@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox