From: Jinseok Kim <always.starving0@gmail.com>
To: kuba@kernel.org
Cc: always.starving0@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, quic_luoj@quicinc.com
Subject: Re: [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h
Date: Thu, 15 Jan 2026 01:11:23 -0800 [thread overview]
Message-ID: <20260115091439.2216-1-always.starving0@gmail.com> (raw)
In-Reply-To: <20260113190210.5387bde1@kernel.org>
Thanks for the review!
I suggested removing the direct #include <linux/dev_printk.h> because
this is the only file under net/ethernet/qualcomm/ that explicitly includes it.
All other files use dev_err() etc. just fine via <linux/device.h>.
But you're right — relying on indirect includes isn't ideal...
I'll leave it as-is for now.
prev parent reply other threads:[~2026-01-15 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 4:20 [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h Jinseok Kim
2026-01-14 3:02 ` Jakub Kicinski
2026-01-15 9:11 ` Jinseok Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115091439.2216-1-always.starving0@gmail.com \
--to=always.starving0@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_luoj@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox