* [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h
@ 2026-01-12 4:20 Jinseok Kim
2026-01-14 3:02 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Jinseok Kim @ 2026-01-12 4:20 UTC (permalink / raw)
To: quic_luoj, andrew+netdev, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, Jinseok Kim
The header <linux/device.h> already includes <linux/dev_printk.h>.
Therefore, explicitly including <linux/dev_printk.h> is unnecessary.
This patch removes the redundant include. No functional changes.
Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
---
drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c b/drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c
index fd959a76ff43..df9f0cdad626 100644
--- a/drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c
+++ b/drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c
@@ -7,7 +7,6 @@
#include <linux/bitfield.h>
#include <linux/debugfs.h>
-#include <linux/dev_printk.h>
#include <linux/device.h>
#include <linux/regmap.h>
#include <linux/seq_file.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h
2026-01-12 4:20 [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h Jinseok Kim
@ 2026-01-14 3:02 ` Jakub Kicinski
2026-01-15 9:11 ` Jinseok Kim
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2026-01-14 3:02 UTC (permalink / raw)
To: Jinseok Kim
Cc: quic_luoj, andrew+netdev, davem, edumazet, pabeni, netdev,
linux-kernel
On Sun, 11 Jan 2026 20:20:38 -0800 Jinseok Kim wrote:
> The header <linux/device.h> already includes <linux/dev_printk.h>.
> Therefore, explicitly including <linux/dev_printk.h> is unnecessary.
>
> This patch removes the redundant include. No functional changes.
Unless there's some effort to remove the dev_printk.h header let's
leave it as is. Depending on header dependencies is not generally
recommended.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h
2026-01-14 3:02 ` Jakub Kicinski
@ 2026-01-15 9:11 ` Jinseok Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jinseok Kim @ 2026-01-15 9:11 UTC (permalink / raw)
To: kuba
Cc: always.starving0, andrew+netdev, davem, edumazet, linux-kernel,
netdev, pabeni, quic_luoj
Thanks for the review!
I suggested removing the direct #include <linux/dev_printk.h> because
this is the only file under net/ethernet/qualcomm/ that explicitly includes it.
All other files use dev_err() etc. just fine via <linux/device.h>.
But you're right — relying on indirect includes isn't ideal...
I'll leave it as-is for now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-15 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-12 4:20 [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h Jinseok Kim
2026-01-14 3:02 ` Jakub Kicinski
2026-01-15 9:11 ` Jinseok Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox