From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Chen Minqiang <ptpt52@gmail.com>,
Xinfa Deng <xinfa.deng@gl-inet.com>
Subject: Re: [PATCH net-next v3 3/6] net: dsa: lantiq: allow arbitrary MII registers
Date: Thu, 15 Jan 2026 19:11:08 -0800 [thread overview]
Message-ID: <20260115191108.1a7eac9f@kernel.org> (raw)
In-Reply-To: <c1b9bc590aa097c98816a3fda6931db9b3d080af.1768519376.git.daniel@makrotopia.org>
On Fri, 16 Jan 2026 00:07:37 +0000 Daniel Golle wrote:
> +__diag_push();
> +__diag_ignore_all("-Woverride-init",
> + "logic to initialize all and then override some is OK");
This seems quite unjustified to save at a glance 4 lines of code.
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-16 3:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 0:06 [PATCH net-next v3 0/6] net: dsa: lantiq: add support for Intel GSW150 Daniel Golle
2026-01-16 0:07 ` [PATCH net-next v3 1/6] dt-bindings: net: dsa: lantiq,gswip: use correct node name Daniel Golle
2026-01-16 0:07 ` [PATCH net-next v3 2/6] dt-bindings: net: dsa: lantiq,gswip: add Intel GSW150 Daniel Golle
2026-01-16 0:07 ` [PATCH net-next v3 3/6] net: dsa: lantiq: allow arbitrary MII registers Daniel Golle
2026-01-16 3:11 ` Jakub Kicinski [this message]
2026-01-16 11:47 ` Daniel Golle
2026-01-16 0:07 ` [PATCH net-next v3 4/6] net: dsa: lantiq: clean up phylink_get_caps switch statement Daniel Golle
2026-01-16 0:07 ` [PATCH net-next v3 5/6] net: dsa: mxl-gsw1xx: only setup SerDes PCS if it exists Daniel Golle
2026-01-16 0:08 ` [PATCH net-next v3 6/6] net: dsa: mxl-gsw1xx: add support for Intel GSW150 Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115191108.1a7eac9f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=ptpt52@gmail.com \
--cc=robh@kernel.org \
--cc=xinfa.deng@gl-inet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox