public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jacky Chou <jacky_chou@aspeedtech.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Jacky Chou <jacky_chou@aspeedtech.com>,
	Simon Horman <horms@kernel.org>
Subject: [PATCH net-next v2 00/15] net: ftgmac100: Various probe cleanups
Date: Fri, 16 Jan 2026 10:09:11 +0800	[thread overview]
Message-ID: <20260116-ftgmac-cleanup-v2-0-81f41f01f2a8@aspeedtech.com> (raw)

The probe function of the ftgmac100 is rather complex, due to the way
it has evolved over time, dealing with poor DT descriptions, and new
variants of the MAC.

Make use of DT match data to identify the MAC variant, rather than
looking at the compatible string all the time.

Make use of devm_ calls to simplify cleanup. This indirectly fixes
inconsistent goto label names.

Always probe the MDIO bus, when it exists. This simplifies the logic a
bit.

Move code into helpers to simply probe.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
Changes in v2:
- Add net-next prefix.
- [08/15] Updated commit message.
- [04/15] Deleted {}.
- Link to v1: https://lore.kernel.org/r/20260105-ftgmac-cleanup-v1-0-b68e4a3d8fbe@aspeedtech.com

---
Andrew Lunn (15):
      net: ftgmac100: List all compatibles
      net: ftgmac100: Add match data containing MAC ID
      net: ftgmac100: Replace all of_device_is_compatible()
      net: ftgmac100: Use devm_alloc_etherdev()
      net: ftgmac100: Use devm_request_memory_region/devm_ioremap
      net: ftgmac100: Use devm_clk_get_enabled
      net: ftgmac100: Simplify error handling for ftgmac100_initial_mac
      net: ftgmac100: Move NCSI probe code into a helper
      net: ftgmac100: Always register the MDIO bus when it exists
      net: ftgmac100: Simplify legacy MDIO setup
      net: ftgmac100: Move DT probe into a helper
      net: ftgmac100: Remove redundant PHY_POLL
      net: ftgmac100: Simplify error handling for ftgmac100_setup_mdio
      net: ftgmac100: Simplify condition on HW arbitration
      net: ftgmac100: Fix wrong netif_napi_del in release

 drivers/net/ethernet/faraday/ftgmac100.c | 305 +++++++++++++++++--------------
 1 file changed, 170 insertions(+), 135 deletions(-)
---
base-commit: d4596891e72cbf155d61798a81ce9d36b69bfaf4
change-id: 20251208-ftgmac-cleanup-20b223bf4681

Best regards,
-- 
Jacky Chou <jacky_chou@aspeedtech.com>


             reply	other threads:[~2026-01-16  2:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16  2:09 Jacky Chou [this message]
2026-01-16  2:09 ` [PATCH net-next v2 01/15] net: ftgmac100: List all compatibles Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 02/15] net: ftgmac100: Add match data containing MAC ID Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 03/15] net: ftgmac100: Replace all of_device_is_compatible() Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 04/15] net: ftgmac100: Use devm_alloc_etherdev() Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 05/15] net: ftgmac100: Use devm_request_memory_region/devm_ioremap Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 06/15] net: ftgmac100: Use devm_clk_get_enabled Jacky Chou
2026-01-20 12:19   ` [net-next,v2,06/15] " Simon Horman
2026-01-22  5:37     ` Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 07/15] net: ftgmac100: Simplify error handling for ftgmac100_initial_mac Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 08/15] net: ftgmac100: Move NCSI probe code into a helper Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 09/15] net: ftgmac100: Always register the MDIO bus when it exists Jacky Chou
2026-01-20 12:14   ` [net-next,v2,09/15] " Simon Horman
2026-01-20 12:21     ` Simon Horman
2026-01-20 14:08     ` Andrew Lunn
2026-01-22  7:31       ` Jacky Chou
2026-01-22 13:40         ` Andrew Lunn
2026-01-24 19:31         ` Andrew Lunn
2026-01-29  6:07           ` Jacky Chou
2026-01-29 13:06             ` Andrew Lunn
2026-02-02  5:29               ` Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 10/15] net: ftgmac100: Simplify legacy MDIO setup Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 11/15] net: ftgmac100: Move DT probe into a helper Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 12/15] net: ftgmac100: Remove redundant PHY_POLL Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 13/15] net: ftgmac100: Simplify error handling for ftgmac100_setup_mdio Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 14/15] net: ftgmac100: Simplify condition on HW arbitration Jacky Chou
2026-01-16  2:09 ` [PATCH net-next v2 15/15] net: ftgmac100: Fix wrong netif_napi_del in release Jacky Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260116-ftgmac-cleanup-v2-0-81f41f01f2a8@aspeedtech.com \
    --to=jacky_chou@aspeedtech.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox