From: Jacky Chou <jacky_chou@aspeedtech.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Jacky Chou <jacky_chou@aspeedtech.com>,
Simon Horman <horms@kernel.org>
Subject: [PATCH net-next v2 03/15] net: ftgmac100: Replace all of_device_is_compatible()
Date: Fri, 16 Jan 2026 10:09:14 +0800 [thread overview]
Message-ID: <20260116-ftgmac-cleanup-v2-3-81f41f01f2a8@aspeedtech.com> (raw)
In-Reply-To: <20260116-ftgmac-cleanup-v2-0-81f41f01f2a8@aspeedtech.com>
From: Andrew Lunn <andrew@lunn.ch>
Now that the priv structure includes the MAC ID, make use of it
instead of the more expensive of_device_is_compatible().
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
drivers/net/ethernet/faraday/ftgmac100.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 104eb7b1f5bb..f07167cabf39 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1720,8 +1720,8 @@ static int ftgmac100_setup_mdio(struct net_device *netdev)
if (!priv->mii_bus)
return -EIO;
- if (of_device_is_compatible(np, "aspeed,ast2400-mac") ||
- of_device_is_compatible(np, "aspeed,ast2500-mac")) {
+ if (priv->mac_id == FTGMAC100_AST2400 ||
+ priv->mac_id == FTGMAC100_AST2500) {
/* The AST2600 has a separate MDIO controller */
/* For the AST2400 and AST2500 this driver only supports the
@@ -1926,9 +1926,9 @@ static int ftgmac100_probe(struct platform_device *pdev)
if (err)
goto err_phy_connect;
- if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac") ||
- of_device_is_compatible(np, "aspeed,ast2500-mac") ||
- of_device_is_compatible(np, "aspeed,ast2600-mac"))) {
+ if (priv->mac_id == FTGMAC100_AST2400 ||
+ priv->mac_id == FTGMAC100_AST2500 ||
+ priv->mac_id == FTGMAC100_AST2600) {
priv->rxdes0_edorr_mask = BIT(30);
priv->txdes0_edotr_mask = BIT(30);
priv->is_aspeed = true;
@@ -1973,8 +1973,8 @@ static int ftgmac100_probe(struct platform_device *pdev)
* available PHYs and register them.
*/
if (of_get_property(np, "phy-handle", NULL) &&
- (of_device_is_compatible(np, "aspeed,ast2400-mac") ||
- of_device_is_compatible(np, "aspeed,ast2500-mac"))) {
+ (priv->mac_id == FTGMAC100_AST2400 ||
+ priv->mac_id == FTGMAC100_AST2500)) {
err = ftgmac100_setup_mdio(netdev);
if (err)
goto err_setup_mdio;
@@ -2026,7 +2026,7 @@ static int ftgmac100_probe(struct platform_device *pdev)
goto err_phy_connect;
/* Disable ast2600 problematic HW arbitration */
- if (of_device_is_compatible(np, "aspeed,ast2600-mac"))
+ if (priv->mac_id == FTGMAC100_AST2600)
iowrite32(FTGMAC100_TM_DEFAULT,
priv->base + FTGMAC100_OFFSET_TM);
}
@@ -2044,11 +2044,11 @@ static int ftgmac100_probe(struct platform_device *pdev)
netdev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER;
/* AST2400 doesn't have working HW checksum generation */
- if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac")))
+ if (priv->mac_id == FTGMAC100_AST2400)
netdev->hw_features &= ~NETIF_F_HW_CSUM;
/* AST2600 tx checksum with NCSI is broken */
- if (priv->use_ncsi && of_device_is_compatible(np, "aspeed,ast2600-mac"))
+ if (priv->use_ncsi && priv->mac_id == FTGMAC100_AST2600)
netdev->hw_features &= ~NETIF_F_HW_CSUM;
if (np && of_get_property(np, "no-hw-checksum", NULL))
--
2.34.1
next prev parent reply other threads:[~2026-01-16 2:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 2:09 [PATCH net-next v2 00/15] net: ftgmac100: Various probe cleanups Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 01/15] net: ftgmac100: List all compatibles Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 02/15] net: ftgmac100: Add match data containing MAC ID Jacky Chou
2026-01-16 2:09 ` Jacky Chou [this message]
2026-01-16 2:09 ` [PATCH net-next v2 04/15] net: ftgmac100: Use devm_alloc_etherdev() Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 05/15] net: ftgmac100: Use devm_request_memory_region/devm_ioremap Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 06/15] net: ftgmac100: Use devm_clk_get_enabled Jacky Chou
2026-01-20 12:19 ` [net-next,v2,06/15] " Simon Horman
2026-01-22 5:37 ` Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 07/15] net: ftgmac100: Simplify error handling for ftgmac100_initial_mac Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 08/15] net: ftgmac100: Move NCSI probe code into a helper Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 09/15] net: ftgmac100: Always register the MDIO bus when it exists Jacky Chou
2026-01-20 12:14 ` [net-next,v2,09/15] " Simon Horman
2026-01-20 12:21 ` Simon Horman
2026-01-20 14:08 ` Andrew Lunn
2026-01-22 7:31 ` Jacky Chou
2026-01-22 13:40 ` Andrew Lunn
2026-01-24 19:31 ` Andrew Lunn
2026-01-29 6:07 ` Jacky Chou
2026-01-29 13:06 ` Andrew Lunn
2026-02-02 5:29 ` Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 10/15] net: ftgmac100: Simplify legacy MDIO setup Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 11/15] net: ftgmac100: Move DT probe into a helper Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 12/15] net: ftgmac100: Remove redundant PHY_POLL Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 13/15] net: ftgmac100: Simplify error handling for ftgmac100_setup_mdio Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 14/15] net: ftgmac100: Simplify condition on HW arbitration Jacky Chou
2026-01-16 2:09 ` [PATCH net-next v2 15/15] net: ftgmac100: Fix wrong netif_napi_del in release Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116-ftgmac-cleanup-v2-3-81f41f01f2a8@aspeedtech.com \
--to=jacky_chou@aspeedtech.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox