From: Paul Moses <p@1g4.org>
To: netdev@vger.kernel.org
Cc: Paul Moses <p@1g4.org>
Subject: [PATCH net v1 1/3] selftests: tc-testing: fix gate replace schedule
Date: Fri, 16 Jan 2026 11:25:57 +0000 [thread overview]
Message-ID: <20260116112522.159480-2-p@1g4.org> (raw)
In-Reply-To: <20260116112522.159480-1-p@1g4.org>
The tdc test case 3719 ("Replace gate base-time action") fails with:
Error: Empty schedule entry list.
We have an error talking to the kernel
The test runs a 'replace' command while only specifying 'base-time' and
omitting the mandatory schedule entries. The act_gate action (and tc
userspace) requires a schedule to be present; replace is atomic and does
not support partial updates or inheriting the previous schedule.
Update the test case to include a valid 'sched-entry' list in the
replace command so it matches the kernel's expected behavior.
Fixes: 4a1db5251cfac ("selftests/tc-testings: add selftests for gate action")
Signed-off-by: Paul Moses <p@1g4.org>
---
tools/testing/selftests/tc-testing/tc-tests/actions/gate.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/gate.json b/tools/testing/selftests/tc-testing/tc-tests/actions/gate.json
index db645c22ad7be..67e406e4eba33 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/gate.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/gate.json
@@ -131,7 +131,7 @@
255
]
],
- "cmdUnderTest": "$TC action replace action gate base-time 400000000000ns index 20",
+ "cmdUnderTest": "$TC action replace action gate base-time 400000000000ns sched-entry open 200000000ns -1 8000000b index 20",
"expExitCode": "0",
"verifyCmd": "$TC action get action gate index 20",
"matchPattern": "action order [0-9]*: .*base-time 400s.*index 20 ref",
--
2.52.GIT
next prev parent reply other threads:[~2026-01-16 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 11:25 [PATCH net v1 0/3] act_gate fixes and gate selftest update Paul Moses
2026-01-16 11:25 ` Paul Moses [this message]
2026-01-16 11:26 ` [PATCH net v1 2/3] net/sched: act_gate: fix schedule updates with RCU swap Paul Moses
2026-01-19 19:12 ` [net,v1,2/3] " Jakub Kicinski
2026-01-16 11:26 ` [PATCH net v1 3/3] net/sched: act_gate: zero-initialize netlink dump struct Paul Moses
2026-01-19 19:14 ` Jakub Kicinski
2026-01-19 18:32 ` [PATCH net v1 0/3] act_gate fixes and gate selftest update Jakub Kicinski
2026-01-19 18:50 ` Paul Moses
2026-01-19 19:12 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116112522.159480-2-p@1g4.org \
--to=p@1g4.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox