From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Paolo Abeni <pabeni@redhat.com>,
linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
davem@davemloft.net
Subject: Re: [can-next 0/5] can: remove private skb headroom infrastructure
Date: Sat, 17 Jan 2026 09:15:43 -0800 [thread overview]
Message-ID: <20260117091543.7881db1a@kernel.org> (raw)
In-Reply-To: <f2d293c1-bc6a-4130-b544-2216ec0b0590@hartkopp.net>
On Fri, 16 Jan 2026 11:31:14 +0100 Oliver Hartkopp wrote:
> Long story short: Using the common pattern to wrap a union around
> dual-usable skb space is the most efficient and least risky solution IMHO.
The concern is that we're making a precedent for, let's call it -
not-routable-networking technology to redefine fields in skb that
it doesn't need. From the maintainability perspective that's a big
risk, IMHO. I fully acknowledge tho that using md dst will be a lot
more work. Which makes this situation an unpleasant judgment call :(
next prev parent reply other threads:[~2026-01-17 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 15:09 [can-next 0/5] can: remove private skb headroom infrastructure Oliver Hartkopp
2026-01-12 15:09 ` [can-next 1/5] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-01-12 15:09 ` [can-next 2/5] can: move can_iif from private headroom to struct sk_buff Oliver Hartkopp
2026-01-12 15:09 ` [can-next 3/5] can: move frame length " Oliver Hartkopp
2026-01-12 15:09 ` [can-next 4/5] can: remove private skb headroom infrastructure Oliver Hartkopp
2026-01-12 15:09 ` [can-next 5/5] can: gw: use new can_gw_hops variable instead of re-using csum_start Oliver Hartkopp
2026-01-14 11:10 ` [can-next 0/5] can: remove private skb headroom infrastructure Oleksij Rempel
2026-01-15 15:37 ` Paolo Abeni
2026-01-16 10:31 ` Oliver Hartkopp
2026-01-17 17:15 ` Jakub Kicinski [this message]
2026-01-18 12:53 ` Oliver Hartkopp
2026-01-21 12:55 ` Oliver Hartkopp
2026-01-21 14:37 ` Marc Kleine-Budde
2026-01-22 17:44 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117091543.7881db1a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox