From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: hkallweit1@gmail.com, linux-kernel@vger.kernel.org,
michael@fossekall.de, linux@armlinux.org.uk, edumazet@google.com,
andrew@lunn.ch, olek2@wp.pl, davem@davemloft.net,
vladimir.oltean@nxp.com, netdev@vger.kernel.org,
pabeni@redhat.com, clm@meta.com
Subject: Re: [v2,2/5] net: phy: realtek: simplify C22 reg access via MDIO_MMD_VEND2
Date: Sat, 17 Jan 2026 15:55:15 -0800 [thread overview]
Message-ID: <20260117155515.5e8a5dba@kernel.org> (raw)
In-Reply-To: <aWwd9LoVI6j8JBTc@makrotopia.org>
On Sat, 17 Jan 2026 23:40:36 +0000 Daniel Golle wrote:
> > > @@ -1156,7 +1156,8 @@ static int rtlgen_read_status(struct phy_device *phydev)
> > > if (!phydev->link)
> > > return 0;
> > >
> > > - val = phy_read(phydev, RTL_PHYSR);
> > > + val = phy_read_paged(phydev, RTL822X_VND2_TO_PAGE(RTL_VND2_PHYSR),
> > > + RTL822X_VND2_TO_PAGE_REG(RTL_VND2_PHYSR));
> >
> > This changes rtlgen_read_status() from reading C22 register MII_RESV2
> > (0x1a) directly to using paged access at page 0xa43, register 18.
>
> Yeah. Just that this is not part of the series submitted.
> It's rather a (halucinated) partial revert of
> [v2,4/5] net: phy: realtek: demystify PHYSR register location
Oh wow, that's a first. No idea how this happened. Is the chunk if
hallucinated from another WIP patch set?
Chris, FWIW this is before we added lore indexing so I don't think
it got it from the list. Is it possible that semcode index is polluted
by previous submissions? Still, even if, it's weird that it'd
hallucinate a chunk of a patch.
Link to the review:
https://netdev-ai.bots.linux.dev/ai-review.html?id=67c40fdf-dd15-4ac1-8571-9425d9a950b4
--
pw-bot: under-review
next prev parent reply other threads:[~2026-01-17 23:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 3:43 [PATCH v2 0/5] net: phy: realtek: simplify and reunify C22/C45 drivers Daniel Golle
2026-01-13 3:44 ` [PATCH v2 1/5] net: phy: realtek: support interrupt also for C22 variants Daniel Golle
2026-01-13 3:44 ` [PATCH v2 2/5] net: phy: realtek: simplify C22 reg access via MDIO_MMD_VEND2 Daniel Golle
2026-01-17 23:20 ` [v2,2/5] " Jakub Kicinski
2026-01-17 23:40 ` Daniel Golle
2026-01-17 23:55 ` Jakub Kicinski [this message]
2026-01-18 0:05 ` Daniel Golle
2026-01-18 0:10 ` Chris Mason
2026-01-18 0:17 ` Jakub Kicinski
2026-01-18 0:35 ` Chris Mason
2026-01-13 3:44 ` [PATCH v2 3/5] net: phy: realtek: reunify C22 and C45 drivers Daniel Golle
2026-01-13 3:44 ` [PATCH v2 4/5] net: phy: realtek: demystify PHYSR register location Daniel Golle
2026-01-13 3:44 ` [PATCH v2 5/5] net: phy: realtek: simplify bogus paged operations Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117155515.5e8a5dba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=clm@meta.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@fossekall.de \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox