From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B071B808; Sun, 18 Jan 2026 02:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768702554; cv=none; b=Sd70TAkGH/OUT94ilNo5CCikq3heB7g31wjo8EQ+qxpbWEjEgsFGFg7PY3MBtsCDeceIzdrdThHM63MZ78d1B2cYiKS1SPN2GUt8F5xCKWSyFsPdP75jIKMhgAYLkp+nMZiaFLpc0zIEYfezB4Hil2jOe21Go1dd8/+gZWRSaOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768702554; c=relaxed/simple; bh=DkTAVOtDgAavmOBCWkEODfmCCxIZofGnZrL0HRHr1+Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pDsoEaJqGmyL7QNM32/HzWJbFTXe650OCfX8YwtHI2lOc+jSgaqgi01BE4fwjRw5a4iSjnQGHbk+3yvVu3JZWq/2RA5YmESavIZcFdWK4tKCS9nbSt2jKe8ahrRH5XmC8OiIfG7SS9pk+hGnacI9PajPM8OkKOVkarQcynZGkvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JkC0leqU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JkC0leqU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A52B3C4CEF7; Sun, 18 Jan 2026 02:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768702554; bh=DkTAVOtDgAavmOBCWkEODfmCCxIZofGnZrL0HRHr1+Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JkC0leqUxhwYx7c9VgSjbs4pehA7gDWJipY4nOB3v8Lj7P/i+eC5nHVlv320j9GT3 BfDGXuRszKLv6NkMGgyPybmhjCvSb1EKn11Lm/LMxbMpFRRT3KtE8TSaFoR7DfwxSu 0aMaCFYCQM3WGigDPntTsfXhQc5J57gW3z5Unee0nMISfGB9pXPbxUb4Z0p0ENQ/g1 91y95gJ2R5G44VmxP9Xvdl56Y1Ez4PAwdvoljSlOWK3Zg++D6K66bK4YtpG1ovXI0q ZiE5bQm5MjqCXDJjFFKv+g5qIRCxEon/tTHgp9iw3YpIt0NWjvnPNVAmyKodfJJlrj VcJY0r6o2ENoQ== Date: Sat, 17 Jan 2026 18:15:51 -0800 From: Jakub Kicinski To: Breno Leitao Cc: Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Saeed Bishara , Bryan Whitehead , UNGLinuxDriver@microchip.com, Shyam Sundar S K , Raju Rangoju , Potnuri Bharat Teja , Nicolas Ferre , Claudiu Beznea , Jiawen Wu , Mengyuan Lou , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 1/9] net: benet: convert to use .get_rx_ring_count Message-ID: <20260117181551.0b139ca1@kernel.org> In-Reply-To: <20260115-grxring_big_v2-v1-1-b3e1b58bced5@debian.org> References: <20260115-grxring_big_v2-v1-0-b3e1b58bced5@debian.org> <20260115-grxring_big_v2-v1-1-b3e1b58bced5@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 15 Jan 2026 06:37:48 -0800 Breno Leitao wrote: > -static int be_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, > - u32 *rule_locs) > -{ > - struct be_adapter *adapter = netdev_priv(netdev); > - > - if (!be_multi_rxq(adapter)) { > - dev_info(&adapter->pdev->dev, > - "ethtool::get_rxnfc: RX flow hashing is disabled\n"); > - return -EINVAL; > - } I think we need to add this check to set_rxfh now. The error coming from get_rxnfc/GRXRINGS effectively shielded the driver from set_rxfh calls ever happening when there's only 1 ring. Now they will happen. Applied the rest