From: David Yang <mmyangfl@gmail.com>
To: netdev@vger.kernel.org
Cc: David Yang <mmyangfl@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v6 2/3] net: dsa: yt921x: Return early for failed MIB read
Date: Sun, 18 Jan 2026 09:30:15 +0800 [thread overview]
Message-ID: <20260118013019.1078847-3-mmyangfl@gmail.com> (raw)
In-Reply-To: <20260118013019.1078847-1-mmyangfl@gmail.com>
This patch does not change anything effectively, but serves as a
prerequisite for another patch.
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/net/dsa/yt921x.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c
index 5e4e8093ba16..fe08385445d2 100644
--- a/drivers/net/dsa/yt921x.c
+++ b/drivers/net/dsa/yt921x.c
@@ -707,6 +707,12 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port)
WRITE_ONCE(*valp, val);
}
+ if (res) {
+ dev_err(dev, "Failed to %s port %d: %i\n", "read stats for",
+ port, res);
+ return res;
+ }
+
pp->rx_frames = mib->rx_64byte + mib->rx_65_127byte +
mib->rx_128_255byte + mib->rx_256_511byte +
mib->rx_512_1023byte + mib->rx_1024_1518byte +
@@ -716,10 +722,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port)
mib->tx_512_1023byte + mib->tx_1024_1518byte +
mib->tx_jumbo;
- if (res)
- dev_err(dev, "Failed to %s port %d: %i\n", "read stats for",
- port, res);
- return res;
+ return 0;
}
static void yt921x_poll_mib(struct work_struct *work)
--
2.51.0
next prev parent reply other threads:[~2026-01-18 1:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 1:30 [PATCH net-next v6 0/3] net: dsa: yt921x: Fix MIB overflow wraparound routine David Yang
2026-01-18 1:30 ` [PATCH net-next v6 1/3] " David Yang
2026-01-22 9:41 ` Paolo Abeni
2026-01-22 13:19 ` Yangfl
2026-01-22 15:21 ` Jakub Kicinski
2026-01-18 1:30 ` David Yang [this message]
2026-01-18 16:06 ` [PATCH net-next v6 2/3] net: dsa: yt921x: Return early for failed MIB read Andrew Lunn
2026-01-18 19:24 ` Yangfl
2026-01-22 9:58 ` Paolo Abeni
2026-01-18 1:30 ` [PATCH net-next v6 3/3] net: dsa: yt921x: Use u64_stats_t for MIB stats David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260118013019.1078847-3-mmyangfl@gmail.com \
--to=mmyangfl@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox