From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Subject: [Patch net v8 8/9] selftests/tc-testing: Update test cases with netem duplicate
Date: Sat, 17 Jan 2026 22:15:14 -0800 [thread overview]
Message-ID: <20260118061515.930322-9-xiyou.wangcong@gmail.com> (raw)
In-Reply-To: <20260118061515.930322-1-xiyou.wangcong@gmail.com>
Now netem does no longer trigger reentrant behaviour of its upper
qdiscs, the whole architecture becomes more solid and less error prone.
Keep these test cases since one of them still sucessfully caught a bug
in QFQ qdisc, but update them to the new netem enqueue behavior.
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
.../tc-testing/tc-tests/infra/qdiscs.json | 50 +++++++++----------
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
index 57e6b5f35070..6cecea3f25ee 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
@@ -579,7 +579,7 @@
},
{
"id": "90ec",
- "name": "Test DRR's enqueue reentrant behaviour with netem",
+ "name": "Test DRR with NETEM duplication",
"category": [
"qdisc",
"drr"
@@ -597,11 +597,11 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 2:0",
"matchJSON": [
{
- "kind": "drr",
- "handle": "1:",
+ "kind": "netem",
+ "handle": "2:",
"bytes": 196,
"packets": 2
}
@@ -614,7 +614,7 @@
},
{
"id": "1f1f",
- "name": "Test ETS's enqueue reentrant behaviour with netem",
+ "name": "Test ETS with NETEM duplication",
"category": [
"qdisc",
"ets"
@@ -632,15 +632,13 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s class show dev $DUMMY",
+ "verifyCmd": "$TC -j -s qdisc show dev $DUMMY handle 2:0",
"matchJSON": [
{
- "class": "ets",
- "handle": "1:1",
- "stats": {
- "bytes": 196,
- "packets": 2
- }
+ "kind": "netem",
+ "handle": "2:",
+ "bytes": 196,
+ "packets": 2
}
],
"matchCount": "1",
@@ -651,7 +649,7 @@
},
{
"id": "5e6d",
- "name": "Test QFQ's enqueue reentrant behaviour with netem",
+ "name": "Test QFQ with NETEM duplication",
"category": [
"qdisc",
"qfq"
@@ -669,11 +667,11 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 2:0",
"matchJSON": [
{
- "kind": "qfq",
- "handle": "1:",
+ "kind": "netem",
+ "handle": "2:",
"bytes": 196,
"packets": 2
}
@@ -686,7 +684,7 @@
},
{
"id": "bf1d",
- "name": "Test HFSC's enqueue reentrant behaviour with netem",
+ "name": "Test HFSC with NETEM duplication",
"category": [
"qdisc",
"hfsc"
@@ -710,13 +708,11 @@
],
"cmdUnderTest": "ping -c 1 10.10.10.2 -I$DUMMY > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 3:0",
"matchJSON": [
{
- "kind": "hfsc",
- "handle": "1:",
- "bytes": 392,
- "packets": 4
+ "kind": "netem",
+ "handle": "3:"
}
],
"matchCount": "1",
@@ -727,7 +723,7 @@
},
{
"id": "7c3b",
- "name": "Test nested DRR's enqueue reentrant behaviour with netem",
+ "name": "Test nested DRR with NETEM duplication",
"category": [
"qdisc",
"drr"
@@ -748,11 +744,11 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 3:0",
"matchJSON": [
{
- "kind": "drr",
- "handle": "1:",
+ "kind": "netem",
+ "handle": "3:",
"bytes": 196,
"packets": 2
}
@@ -827,7 +823,7 @@
},
{
"id": "309e",
- "name": "Test HFSC eltree double add with reentrant enqueue behaviour on netem",
+ "name": "Test complex HFSC with NETEM duplication",
"category": [
"qdisc",
"hfsc"
--
2.34.1
next prev parent reply other threads:[~2026-01-18 6:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 6:15 [Patch net v8 0/9] netem: Fix skb duplication logic and prevent infinite loops Cong Wang
2026-01-18 6:15 ` [Patch net v8 1/9] net_sched: Check the return value of qfq_choose_next_agg() Cong Wang
2026-01-18 6:15 ` [Patch net v8 2/9] Revert "net/sched: Restrict conditions for adding duplicating netems to qdisc tree" Cong Wang
2026-01-18 6:15 ` [Patch net v8 3/9] Revert "selftests/tc-testing: Add tests for restrictions on netem duplication" Cong Wang
2026-01-18 6:15 ` [Patch net v8 4/9] net_sched: Implement the right netem duplication behavior Cong Wang
2026-01-18 6:15 ` [Patch net v8 5/9] selftests/tc-testing: Add a nested netem duplicate test Cong Wang
2026-01-18 6:15 ` [Patch net v8 6/9] selftests/tc-testing: Add a test case for prio with netem duplicate Cong Wang
2026-01-18 6:15 ` [Patch net v8 7/9] selftests/tc-testing: Add a test case for mq " Cong Wang
2026-01-18 6:15 ` Cong Wang [this message]
2026-01-18 6:15 ` [Patch net v8 9/9] selftests/tc-testing: Add a test case for HTB with netem Cong Wang
2026-01-18 15:07 ` [Patch net v8 0/9] netem: Fix skb duplication logic and prevent infinite loops Jamal Hadi Salim
2026-01-21 17:08 ` Simon Horman
2026-01-21 18:50 ` Jamal Hadi Salim
2026-01-27 17:15 ` Jakub Kicinski
2026-01-30 20:53 ` Cong Wang
2026-01-30 21:18 ` Jakub Kicinski
2026-01-30 21:32 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260118061515.930322-9-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox