From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH v2 net-next 0/3] gro: inline tcp6_gro_{receive,complete}
Date: Sun, 18 Jan 2026 17:52:12 +0000 [thread overview]
Message-ID: <20260118175215.2871535-1-edumazet@google.com> (raw)
On some platforms, GRO stack is too deep and causes cpu stalls.
Decreasing call depths by one shows a 1.5 % gain on Zen2 cpus.
(32 RX queues, 100Gbit NIC, RFS enabled, tcp_rr with 128 threads and 10,000 flows)
We can go further by inlining ipv6_gro_{receive,complete}
and take care of IPv4 if there is interest.
Note: two temporary __always_inline will be replaced with
inline_for_performance when available.
v2: dealt with udp6_gro_receive()/udp6_gro_complete()
missing declarations (kernel test robot <lkp@intel.com>)
for CONFIG_MITIGATION_RETPOLINE=n
Cumulative size increase for this series (of 3):
$ scripts/bloat-o-meter -t vmlinux.0 vmlinux.3
add/remove: 2/2 grow/shrink: 5/1 up/down: 1572/-471 (1101)
Function old new delta
ipv6_gro_receive 1069 1846 +777
ipv6_gro_complete 433 733 +300
tcp6_check_fraglist_gro - 272 +272
tcp6_gro_complete 227 306 +79
tcp4_gro_complete 325 397 +72
ipv6_offload_init 218 274 +56
__pfx_tcp6_check_fraglist_gro - 16 +16
__pfx___skb_incr_checksum_unnecessary 32 - -32
__skb_incr_checksum_unnecessary 186 - -186
tcp6_gro_receive 959 706 -253
Total: Before=22592724, After=22593825, chg +0.00%
Eric Dumazet (3):
net: always inline __skb_incr_checksum_unnecessary()
gro: inline tcp6_gro_receive()
gro: inline tcp6_gro_complete()
include/linux/skbuff.h | 2 +-
include/net/gro.h | 5 ++---
include/net/tcp.h | 2 --
net/ipv6/Makefile | 2 +-
net/ipv6/ip6_offload.c | 43 ++++++++++++++++++++--------------------
net/ipv6/tcpv6_offload.c | 12 +++++------
6 files changed, 31 insertions(+), 35 deletions(-)
--
2.52.0.457.g6b5491de43-goog
next reply other threads:[~2026-01-18 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 17:52 Eric Dumazet [this message]
2026-01-18 17:52 ` [PATCH v2 net-next 1/3] net: always inline __skb_incr_checksum_unnecessary() Eric Dumazet
2026-01-18 17:52 ` [PATCH v2 net-next 2/3] gro: inline tcp6_gro_receive() Eric Dumazet
2026-01-18 17:52 ` [PATCH v2 net-next 3/3] gro: inline tcp6_gro_complete() Eric Dumazet
2026-01-20 15:30 ` [PATCH v2 net-next 0/3] gro: inline tcp6_gro_{receive,complete} Jakub Kicinski
2026-01-20 15:41 ` Eric Dumazet
2026-01-20 15:44 ` Eric Dumazet
2026-01-20 16:29 ` Jakub Kicinski
2026-01-20 16:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260118175215.2871535-1-edumazet@google.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox