From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [net,v2] rxrpc: Fix data-race warning and potential load/store tearing
Date: Mon, 19 Jan 2026 09:39:45 -0800 [thread overview]
Message-ID: <20260119093945.7929e3cb@kernel.org> (raw)
In-Reply-To: <916127.1768737781@warthog.procyon.org.uk>
On Sun, 18 Jan 2026 12:03:01 +0000 David Howells wrote:
> Jakub Kicinski <kuba@kernel.org> wrote:
>
> > > + (s32)now - (s32)peer->last_tx_at,
> > ^^^^^^^^^^^^^^^^^
> >
> > Should this read use READ_ONCE(peer->last_tx_at) for consistency with the
> > data-race fix? The new rxrpc_peer_get_tx_mark() uses READ_ONCE for the
> > same field, and the same seq_printf uses READ_ONCE for recent_srtt_us and
> > recent_rto_us on the following lines.
>
> I suppose. Racing doesn't matter here as it's just displaying the value;
> tearing might matter, but it's now a 32-bit field.
Right, total nit pick. It's mostly for consistency with other fields in
the same print statement that are READ_ONCE()d.
next prev parent reply other threads:[~2026-01-19 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 21:36 [PATCH net v2] rxrpc: Fix data-race warning and potential load/store tearing David Howells
2026-01-18 0:24 ` [net,v2] " Jakub Kicinski
2026-01-18 12:03 ` David Howells
2026-01-19 17:39 ` Jakub Kicinski [this message]
2026-01-19 23:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119093945.7929e3cb@kernel.org \
--to=kuba@kernel.org \
--cc=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox