From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Felix Fietkau <nbd@nbd.name>,
Sean Wang <sean.wang@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Shay Agroskin <shayagr@amazon.com>,
Arthur Kiyanovski <akiyano@amazon.com>,
David Arinzon <darinzon@amazon.com>,
Saeed Bishara <saeedb@amazon.com>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Raju Rangoju <Raju.Rangoju@amd.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 1/9] net: benet: convert to use .get_rx_ring_count
Date: Mon, 19 Jan 2026 09:45:14 -0800 [thread overview]
Message-ID: <20260119094514.5b12a097@kernel.org> (raw)
In-Reply-To: <l66l2ijd45fkwniaesgau5jdzoxrdyt4t7tnsd6dpo4dlefytf@tugyhkn2th36>
On Mon, 19 Jan 2026 04:56:49 -0800 Breno Leitao wrote:
> > > I think we need to add this check to set_rxfh now. The error coming
> > > from get_rxnfc/GRXRINGS effectively shielded the driver from set_rxfh
> > > calls ever happening when there's only 1 ring. Now they will happen.
> >
> > You are absolutely correct. The ethtool core calls
> > get_rxnfc(ETHTOOL_GRXRINGS) _before_ allowing RSS configuration via
> > set_rxfh, and if it fails, ethtool_set_rxfh() will fail as well. And
> > with the current change, ethtool_set_rxfh() will not fail if the adapter
> > is not multi-queue.
>
> Upon further consideration, should we implement this limitation directly within
> the ethtool infrastructure?
That may cause some regressions, we're getting the number of currently
configured Rx rings. If we were to check how many Rx rings the device
has that'd make sense. But since we can only access currently
configured rings, in theory, if the device has multiple rings,
just only one is active now - changing config for the RSS key or
function should work just fine. IOW
# change key
# increase ring count to make they key meaningful
Used to work.
next prev parent reply other threads:[~2026-01-19 17:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:37 [PATCH net-next 0/9] net: convert drivers to .get_rx_ring_count (part 2) Breno Leitao
2026-01-15 14:37 ` [PATCH net-next 1/9] net: benet: convert to use .get_rx_ring_count Breno Leitao
2026-01-18 2:15 ` Jakub Kicinski
2026-01-19 11:07 ` Breno Leitao
2026-01-19 12:56 ` Breno Leitao
2026-01-19 17:45 ` Jakub Kicinski [this message]
2026-01-15 14:37 ` [PATCH net-next 2/9] net: tsnep: " Breno Leitao
2026-01-15 14:37 ` [PATCH net-next 3/9] net: mediatek: " Breno Leitao
2026-01-15 14:37 ` [PATCH net-next 4/9] net: ena: " Breno Leitao
2026-01-15 17:51 ` Kiyanovski, Arthur
2026-01-15 14:37 ` [PATCH net-next 5/9] net: lan743x: " Breno Leitao
2026-01-15 14:37 ` [PATCH net-next 6/9] net: xgbe: " Breno Leitao
2026-01-19 12:10 ` Rangoju, Raju
2026-01-15 14:37 ` [PATCH net-next 7/9] net: cxgb4: " Breno Leitao
2026-01-15 14:37 ` [PATCH net-next 8/9] net: macb: " Breno Leitao
2026-01-19 13:08 ` Nicolas Ferre
2026-01-15 14:37 ` [PATCH net-next 9/9] net: txgbe: " Breno Leitao
2026-01-19 14:19 ` [PATCH net-next 0/9] net: convert drivers to .get_rx_ring_count (part 2) patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-01-21 15:54 [PATCH net-next 0/9] net: convert drivers to .get_rx_ring_count (last part) Breno Leitao
2026-01-21 15:54 ` [PATCH net-next 1/9] net: benet: convert to use .get_rx_ring_count Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119094514.5b12a097@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akiyano@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bharat@chelsio.com \
--cc=bryan.whitehead@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mengyuanlou@net-swift.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=sean.wang@mediatek.com \
--cc=shayagr@amazon.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox