From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linusw@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support
Date: Mon, 19 Jan 2026 23:58:18 +0200 [thread overview]
Message-ID: <20260119215818.qiaqdudcz32nk7f2@skbuf> (raw)
In-Reply-To: <20260119-ks8995-fixups-v2-2-98bd034a0d12@kernel.org>
On Mon, Jan 19, 2026 at 03:30:06PM +0100, Linus Walleij wrote:
> After studying the datasheets for a bit, I can conclude that
> the register maps for the two KSZ variants explicitly said to
> be supported by this driver are fully supported by the newer
> Micrel KSZ driver, including full VLAN support and a different
> custom tag than what the KS8995 is using.
>
> Delete this support, users should be using the KSZ driver
> CONFIG_NET_DSA_MICROCHIP_KSZ_SPI and any new device trees should
> use:
> micrel,ksz8864 -> microchip,ksz8864
> micrel,ksz8795 -> microchip,ksz8795
So the binding changes you've done to Documentation/devicetree/bindings/net/micrel-ks8995.txt
in commit a0f29a07b654 ("dt-bindings: dsa: Rewrite Micrel KS8995 in schema")
were apparently backwards-compatible. But this isn't - you're offering
no forward path for existing device trees.
IMO, even if nobody cares about these compatible strings (given that the
"PHY" driver dates from 2016 and the KSZ DSA driver has supported these
chips since 2019), IMO it's pretty hard to sell a loss of hardware support
in a patch set targeted to 'net'.
Does it make more sense to retarget the patches to 'net-next', drop
the Fixes: tags and to somehow mark the driver as "experimental", to set
the expectations about the fact that it's still under development and
many things aren't how they should be?
>
> Apparently Microchip acquired Micrel at some point and this
> created the confusion.
>
> Fixes: a7fe8b266f65 ("net: dsa: ks8995: Add basic switch set-up")
> Reported-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
> drivers/net/dsa/ks8995.c | 160 +++++++++--------------------------------------
> 1 file changed, 28 insertions(+), 132 deletions(-)
next prev parent reply other threads:[~2026-01-19 21:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 14:30 [PATCH net-next v2 0/4] net: dsa: ks8995: Post-move fixes Linus Walleij
2026-01-19 14:30 ` [PATCH net-next v2 1/4] net: dsa: ks8995: Add shutdown callback Linus Walleij
2026-01-19 15:38 ` Vladimir Oltean
2026-01-19 16:33 ` Jakub Kicinski
2026-01-19 16:40 ` Vladimir Oltean
2026-01-19 20:26 ` Linus Walleij
2026-01-19 14:30 ` [PATCH net-next v2 2/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support Linus Walleij
2026-01-19 16:34 ` [net-next,v2,2/4] " Jakub Kicinski
2026-01-19 21:58 ` Vladimir Oltean [this message]
2026-01-19 23:26 ` [PATCH net-next v2 2/4] " Linus Walleij
2026-01-19 14:30 ` [PATCH net-next v2 3/4] net: dsa: ks8995: Add stub bridge join/leave Linus Walleij
2026-01-19 22:20 ` Vladimir Oltean
2026-01-19 14:30 ` [PATCH net-next v2 4/4] net: dsa: ks8995: Implement port isolation Linus Walleij
2026-01-19 22:48 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119215818.qiaqdudcz32nk7f2@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox