From: Greg KH <greg@kroah.com>
To: insyelu <insyelu@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, nic_swsd@realtek.com,
tiwai@suse.de, hayeswang@realtek.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: usb: r8152: fix transmit queue timeout
Date: Mon, 19 Jan 2026 07:40:52 +0100 [thread overview]
Message-ID: <2026011928-eggbeater-manhunt-d3a1@gregkh> (raw)
In-Reply-To: <20260119022802.3705-1-insyelu@gmail.com>
On Mon, Jan 19, 2026 at 10:28:02AM +0800, insyelu wrote:
> When the TX queue length reaches the threshold, the netdev watchdog
> immediately detects a TX queue timeout.
>
> This patch updates the trans_start timestamp of the transmit queue
> on every asynchronous USB URB submission along the transmit path,
> ensuring that the network watchdog accurately reflects ongoing
> transmission activity.
>
> Signed-off-by: insyelu <insyelu@gmail.com>
> ---
> v2: Update the transmit timestamp when submitting the USB URB.
> ---
> drivers/net/usb/r8152.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index fa5192583860..880b59ed5422 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -2449,6 +2449,8 @@ static int r8152_tx_agg_fill(struct r8152 *tp, struct tx_agg *agg)
> ret = usb_submit_urb(agg->urb, GFP_ATOMIC);
> if (ret < 0)
> usb_autopm_put_interface_async(tp->intf);
> + else
> + netif_trans_update(tp->netdev);
>
> out_tx_fill:
> return ret;
> --
> 2.34.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2026-01-19 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 2:28 [PATCH v2] net: usb: r8152: fix transmit queue timeout insyelu
2026-01-19 6:40 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-20 1:59 Mingj Ye
2026-01-20 2:49 ` Hayes Wang
2026-01-21 2:40 ` patchwork-bot+netdevbpf
2026-01-19 10:56 insyelu
2026-01-19 11:07 ` Greg KH
2026-01-14 2:56 [PATCH] " insyelu
2026-01-16 2:37 ` [PATCH v2] " insyelu
2026-01-16 17:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011928-eggbeater-manhunt-d3a1@gregkh \
--to=greg@kroah.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=insyelu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox