From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2D830148D for ; Tue, 20 Jan 2026 16:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768926584; cv=none; b=j3dV+r/e/WoqKD72aMV7/p5Rd6Ja+3ArkQiAh19J+RN92l09S7vucmqdbY8f3JjeoM+4MXQp32hfiuC+zCnc+3WIAkecsCoW7oZCiMcxNXgfQtuWOvEeOFG0gUuoRfzwD+vpQ4AjI1Cp2ZjhGBWeBHC8f4qHN89sclNKYstysbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768926584; c=relaxed/simple; bh=apk87Dee/Cxfz6Ep8pQTt6khD8mITgr3FiU+0g3v4o4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NEK9oWcpxaceOtg0jkjUyEmzZdfqFUMYKGBcSgrngpn+5ekTG9FsZkL0G8MYJQhNmRxgYDN8U5z0rB3xli/YGvoy9OOcTsiriBiABeNXZrZx61YBnpOy6espnAfscETxF5O90hxbMysUU5SyxZ1VmSH5VXjIoY8evpVT7WwgNs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m7qh+lF3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m7qh+lF3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85E48C16AAE; Tue, 20 Jan 2026 16:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768926583; bh=apk87Dee/Cxfz6Ep8pQTt6khD8mITgr3FiU+0g3v4o4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m7qh+lF38sdUDVdih9bMjbNeWq1K6zyHt8yxyczmtQLvv4USnX5lkdoPywBgkEs+0 Z+RB6phvFqRyhQdJMlfvIsPnqKZuEUqr3jVnajZW+781BW6Kae8m91DzrpxD3k3rum Zez8VtvxIPAP2KMuXtum/DboegGHHX3uBLN2t1uzazQWHyaWfkoimIEHrkkSARr9iL Vxjmxx+/clXbjzH2lh6yosi9X+EjpaNWKcfUnT65Bwo5y/o1lGOBSMj9ht3q5RlgeJ jPo5s+ufEyvMug0Btq7CAdYRKYbHaRJGMY/jvSFcfFoeuKWod5N6AHXucO5Dxu0tQp Fmj7g9O1j8jpQ== Date: Tue, 20 Jan 2026 08:29:42 -0800 From: Jakub Kicinski To: Eric Dumazet Cc: "David S . Miller" , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH v2 net-next 0/3] gro: inline tcp6_gro_{receive,complete} Message-ID: <20260120082942.3c62738b@kernel.org> In-Reply-To: References: <20260118175215.2871535-1-edumazet@google.com> <20260120073057.5ef3a5e1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 20 Jan 2026 16:44:52 +0100 Eric Dumazet wrote: > On Tue, Jan 20, 2026 at 4:41=E2=80=AFPM Eric Dumazet wrote: > > > Still not good? > > > > > > net/ipv6/udp_offload.c:136:17: error: static declaration of =E2=80=98= udp6_gro_receive=E2=80=99 follows non-static declaration > > > 136 | struct sk_buff *udp6_gro_receive(struct list_head *head, stru= ct sk_buff *skb) > > > | ^~~~~~~~~~~~~~~~ > > > In file included from net/ipv6/udp_offload.c:16: > > > ./include/net/gro.h:408:17: note: previous declaration of =E2=80=98ud= p6_gro_receive=E2=80=99 with type =E2=80=98struct sk_buff *(struct list_hea= d *, struct sk_buff *)=E2=80=99 > > > 408 | struct sk_buff *udp6_gro_receive(struct list_head *, struct s= k_buff *); > > > | ^~~~~~~~~~~~~~~~ > > > net/ipv6/udp_offload.c:168:29: error: static declaration of =E2=80=98= udp6_gro_complete=E2=80=99 follows non-static declaration > > > 168 | INDIRECT_CALLABLE_SCOPE int udp6_gro_complete(struct sk_buff = *skb, int nhoff) > > > | ^~~~~~~~~~~~~~~~~ > > > ./include/net/gro.h:409:5: note: previous declaration of =E2=80=98udp= 6_gro_complete=E2=80=99 with type =E2=80=98int(struct sk_buff *, int)=E2=80= =99 > > > 409 | int udp6_gro_complete(struct sk_buff *, int); > > > | ^~~~~~~~~~~~~~~~~ =20 > > > > Oh well, I thought I tested this stuff. =20 >=20 > Interesting... clang (our default compiler for kernel) does not complain = at all. Well, at least I _think_ it's this series, haven't tested. It breaks in the kselftests, no allmodconfig, here's the full config: https://netdev-ctrl.bots.linux.dev/logs/vmksft/packetdrill-dbg/results/4820= 21/config Also possible that it's a silent conflict with another pending series.