From: Jakub Slepecki <jakub.slepecki@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
michal.swiatkowski@linux.intel.com, jakub.slepecki@intel.com,
aleksandr.loktionov@intel.com
Subject: [PATCH iwl-next v3 3/8] ice: do not check for zero mac when creating mac filters
Date: Tue, 20 Jan 2026 11:34:34 +0100 [thread overview]
Message-ID: <20260120103440.892326-4-jakub.slepecki@intel.com> (raw)
In-Reply-To: <20260120103440.892326-1-jakub.slepecki@intel.com>
A zero MAC address was considered a special case while creating a new
MAC filter. There is no particular reason for that other than the fact
that the union containing it was assumed to be zeroed out. Now, address
is pulled out of the union by ice_fltr_mac_address which checks all of
the previously assumed zero-address cases and returns an error if they
are hit.
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Jakub Slepecki <jakub.slepecki@intel.com>
---
No changes in v3.
No changes in v2.
---
drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 0275e2910c6b..04e5d653efce 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -3648,7 +3648,7 @@ int ice_add_mac(struct ice_hw *hw, struct list_head *m_list)
u16 hw_vsi_id;
err = ice_fltr_mac_address(addr, &m_list_itr->fltr_info);
- if (err || is_zero_ether_addr(addr))
+ if (err)
return -EINVAL;
m_list_itr->fltr_info.flag = ICE_FLTR_TX;
vsi_handle = m_list_itr->fltr_info.vsi_handle;
--
2.43.0
next prev parent reply other threads:[~2026-01-20 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 10:34 [PATCH iwl-next v3 0/8] ice: in VEB, prevent "cross-vlan" traffic Jakub Slepecki
2026-01-20 10:34 ` [PATCH iwl-next v3 1/8] ice: in dvm, use outer VLAN in MAC,VLAN lookup Jakub Slepecki
2026-01-20 10:34 ` [PATCH iwl-next v3 2/8] ice: allow creating mac,vlan filters along mac filters Jakub Slepecki
2026-01-20 10:34 ` Jakub Slepecki [this message]
2026-01-26 23:21 ` [PATCH iwl-next v3 3/8] ice: do not check for zero mac when creating " Tony Nguyen
2026-01-27 10:31 ` Jakub Slepecki
2026-01-27 18:45 ` Tony Nguyen
2026-01-20 10:34 ` [PATCH iwl-next v3 4/8] ice: allow overriding lan_en, lb_en in switch Jakub Slepecki
2026-01-20 10:34 ` [PATCH iwl-next v3 5/8] ice: update mac,vlan rules when toggling between VEB and VEPA Jakub Slepecki
2026-01-20 10:34 ` [PATCH iwl-next v3 6/8] ice: add functions to query for vsi's pvids Jakub Slepecki
2026-01-20 10:34 ` [PATCH iwl-next v3 7/8] ice: add mac vlan to filter API Jakub Slepecki
2026-01-20 10:34 ` [PATCH iwl-next v3 8/8] ice: in VEB, prevent "cross-vlan" traffic from hitting loopback Jakub Slepecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120103440.892326-4-jakub.slepecki@intel.com \
--to=jakub.slepecki@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox