[PATCH net-next] selftests: drv-net: fix missing include in ncdevmem

[PATCH net-next] selftests: drv-net: fix missing include in ncdevmem

[Jakub Kicinski]

Commit ca9d74eb5f6a ("uapi: add INT_MAX and INT_MIN constants")
recently removed some includes of limits.h in uAPI headers.
ncdevmem.c was depending on them:

  ncdevmem.c: In function ‘ethtool_add_flow’:
  ncdevmem.c:369:60: error: ‘INT_MAX’ undeclared (first use in this function)
  369 |         if (endptr == id_start || flow_id < 0 || flow_id > INT_MAX)
      |                                                            ^~~~~~~
  ncdevmem.c:77:1: note: ‘INT_MAX’ is defined in header ‘<limits.h>’; did you forget to ‘#include <limits.h>’?

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: shuah@kernel.org
CC: sdf@fomichev.me
CC: almasrymina@google.com
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/drivers/net/hw/ncdevmem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
index 3288ed04ce08..16864c844108 100644
--- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c
+++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
@@ -48,6 +48,7 @@
 #include <errno.h>
 #define __iovec_defined
 #include <fcntl.h>
+#include <limits.h>
 #include <malloc.h>
 #include <error.h>
 #include <poll.h>
-- 
2.52.0

Re: [PATCH net-next] selftests: drv-net: fix missing include in ncdevmem

[Mina Almasry]

On Tue, Jan 20, 2026 at 10:03 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Commit ca9d74eb5f6a ("uapi: add INT_MAX and INT_MIN constants")
> recently removed some includes of limits.h in uAPI headers.
> ncdevmem.c was depending on them:
>
>   ncdevmem.c: In function ‘ethtool_add_flow’:
>   ncdevmem.c:369:60: error: ‘INT_MAX’ undeclared (first use in this function)
>   369 |         if (endptr == id_start || flow_id < 0 || flow_id > INT_MAX)
>       |                                                            ^~~~~~~
>   ncdevmem.c:77:1: note: ‘INT_MAX’ is defined in header ‘<limits.h>’; did you forget to ‘#include <limits.h>’?
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Mina Almasry <almasrymina@google.com>



-- 
Thanks,
Mina

Re: [PATCH net-next] selftests: drv-net: fix missing include in ncdevmem

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 20 Jan 2026 10:03:19 -0800 you wrote:
> Commit ca9d74eb5f6a ("uapi: add INT_MAX and INT_MIN constants")
> recently removed some includes of limits.h in uAPI headers.
> ncdevmem.c was depending on them:
> 
>   ncdevmem.c: In function ‘ethtool_add_flow’:
>   ncdevmem.c:369:60: error: ‘INT_MAX’ undeclared (first use in this function)
>   369 |         if (endptr == id_start || flow_id < 0 || flow_id > INT_MAX)
>       |                                                            ^~~~~~~
>   ncdevmem.c:77:1: note: ‘INT_MAX’ is defined in header ‘<limits.h>’; did you forget to ‘#include <limits.h>’?
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: drv-net: fix missing include in ncdevmem
    https://git.kernel.org/netdev/net-next/c/1802e9079f65

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html