From: Ido Schimmel <idosch@nvidia.com>
To: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Petr Machata <petrm@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] selftests: forwarding: skip tests when kernel or userspace support is missing
Date: Wed, 21 Jan 2026 14:24:03 +0200 [thread overview]
Message-ID: <20260121122403.GA458529@shredder> (raw)
In-Reply-To: <20260120230208.328337-1-aleksey.oladko@virtuozzo.com>
On Tue, Jan 20, 2026 at 11:02:02PM +0000, Aleksei Oladko wrote:
> Hi,
>
> Several forwarding selftests currently assume that certain kernel
> features or tc/ip capabilities are always present. When this is no the
> case (e.g. kernel built without specific CONFIG options or older
> iproute2).
>
> This series adds explicit feature probing and conditional skips to
> avoid false negatives.
>
> Summary of changes:
> 1. forwarding/lib: skip tests that require LAG devices when the team
> driver is not supported (CONFIG_NET_TEAM disabled)
> 2. forwarding/sch_ets: skip tests if the cls_basic module is not
> available (CONFIG_NET_CLS_BASIC disabled)
Both are mentioned in tools/testing/selftests/net/forwarding/config
> 3. forwarding/lib introduce run_cmd_grep helper to probe userspace
> feature support by matching keywords in command help output
> 4. forwarding/tc_flower_cfm: skip test when tc does not support cfm
> 5. forwarding/tc_flower_l2_miss: skip test when tc does not support
> l2_miss
Both are present in iproute2 v6.5 (September 2023).
> 6. forwarding/router_mpath_seed: skip tests then ip does not support
> hw_stats
Present in iproute2 v6.10 (July 2024).
Latest version is v6.18.
I don't see the point in running netdev selftests with such old
versions. Especially when it should be relatively easy to put a new
version in PATH
prev parent reply other threads:[~2026-01-21 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 23:02 [PATCH 0/6] selftests: forwarding: skip tests when kernel or userspace support is missing Aleksei Oladko
2026-01-20 23:02 ` [PATCH 1/6] selftests: forwarding: lib: skip test if team driver is not supported Aleksei Oladko
2026-01-20 23:02 ` [PATCH 2/6] selftests: forwarding: sch_ets: skip test if cls_basic module is missing Aleksei Oladko
2026-01-20 23:02 ` [PATCH 3/6] selftests: forwarding: lib: add run_cmd_grep helper for feature probing Aleksei Oladko
2026-01-20 23:02 ` [PATCH 4/6] selftests: forwarding: tc_flower_cfm: skip tests if tools or feats are missing Aleksei Oladko
2026-01-20 23:02 ` [PATCH 5/6] selftests: forwarding: tc_flower_l2_miss: " Aleksei Oladko
2026-01-20 23:02 ` [PATCH 6/6] selftests: forwarding: router_mpath_seed: " Aleksei Oladko
2026-01-21 12:24 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121122403.GA458529@shredder \
--to=idosch@nvidia.com \
--cc=aleksey.oladko@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox