From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E022272E56; Thu, 22 Jan 2026 01:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769044253; cv=none; b=FbwYfWq1q1bXyay7mOGlYtEmeD+AVYJRQPO3NvL+nZlVrOT4nxcZkHAP2ujSL6hXeyiX92X4I7jzfhIDW71gnyVVSxjNoO7BYQCl8NnkL6k8RH+XqnjKGwlhwVubjG25AQQS1+dltVmhCES7JlXAWsB1qBK9x/5UQvvkRGtlSDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769044253; c=relaxed/simple; bh=SnjxMNrpiXts4MyVSCyZNLR8uqtfwWGMPW8+wfeXfX0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L8vEzzND+zyr0UwT9jQKogwkzd0PTtSMBwbi5NS1JOZ6eN6JQ7Xla78dPbOAx+AKsR57Otzjbhng/+5M8FMM3OBoUV72SEnBr8NfzsaHJ/BX8aGBdd1aYviUNsxqmQXQJ4P43dQZ3vTaYntMnxxGMnAysb0exHph59zCTjJGP8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tYr9FmMI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tYr9FmMI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82E97C4CEF1; Thu, 22 Jan 2026 01:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769044253; bh=SnjxMNrpiXts4MyVSCyZNLR8uqtfwWGMPW8+wfeXfX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tYr9FmMIjBvbndlH762oetJSktbdyFN6oDz6TM1jyJeal/huS/HYmgHLG3YZiKzHA RqBRpgPJcab0XmPWi10sKgdgyqCnaYyukoCXytEBq60rSYyl88oLVe5EiGidZKmw/A JhR9TY/JbLAXQKeaJ/IiTEhK9cEsCY7UHMXi9wNe2bRiAKJXuvHruJOVqOxjTHP3XY TBGjgwlFGHwVeqsq/gbbvRf1iNndJM3yJYqU2zm8thhXwopnkHKsbQL+P2UHcjVaQ7 v8Mtpebldh15OlOmJHc6L+RONuftV2pEv6mckdHYcDEcNaWXj1irHasvtnunIBXioV 7MxdknmchPKjg== Date: Wed, 21 Jan 2026 17:10:51 -0800 From: Jakub Kicinski To: Paolo Abeni Cc: Hangbin Liu , netdev@vger.kernel.org, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Simon Horman , Mahesh Bandewar , Shuah Khan , linux-kselftest@vger.kernel.org, Liang Li Subject: Re: [PATCHv2 net-next 2/3] bonding: restructure ad_churn_machine Message-ID: <20260121171051.039110c3@kernel.org> In-Reply-To: References: <20260114064921.57686-1-liuhangbin@gmail.com> <20260114064921.57686-3-liuhangbin@gmail.com> <20260119122203.5113b16f@kernel.org> <71e30492-7644-4d4f-aaab-9a505f8faae3@redhat.com> <20260120151109.2d483bd8@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 21 Jan 2026 08:58:13 +0100 Paolo Abeni wrote: > >> My personal preference would be for 2/3 landing into net-next: the code > >> looks correct to me, but refactor has IMHO still to much potential for > >> regressions do land directly into net and the blamed commit is quite o= ld. > >> > >> I suggested targeting net-next while retaining the Fixes tag as we > >> already had complex fixes landing into net-next in the past. =20 > >=20 > > The appropriate way to delay propagation of the fix to add: > >=20 > > Cc: # after 4 weeks > >=20 > > not to merge things into -next. =20 >=20 > I went over the code as carefully as I could and I don't see any obvious > problem, so I don't have a so strong opinion vs net, but to hopefully > clarify: my thinking is that this is net-next material because it's an > invasive refactor with behavior change. My preference would be let the > code be tested in next/net-next for a while before landing into mainline. =46rom the patch description it look like user-trigger-able hang of=20 the FSM. But if this is more of a resiliency improvement than a fix then I'm perfectly fine with net-next. But then no Fixes tag and=20 no stable at all, please.