From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712873E03E6; Thu, 22 Jan 2026 16:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769098507; cv=none; b=tu5gvMwZwFLaBkqNZCaFvw9ytNVJdquy9/8vxI/DCl8rcIjI8DDX7EjIZwbKVV4pwn0n9msZIkhDowqpoD9w6boIiJE8cr+BSDoipk7jo9CJksvhPqrunrqc7UJuggTFOXdxMPQoN8sB0e2DnSvuy2s3VPz7ms/p0DLvS9jr/60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769098507; c=relaxed/simple; bh=SJFHQ6Dsh1f3ySZRRJ37Il23iv7ykfQoJASPEADlhj4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=hLxrJl9ralebwsMj9UQq6NFs0VyuQ99IPKlv671WcCL+ATutbniZv1ZQhvSrxjUi8ld/hzOAiJQFfL7jV+zE7jECgSTqfkypVuav2Ti4kMGWbSFOvTatCE25pkH+8x3e8FXxLoVSXdD4te/rEai4ZyAtP+v+X/66S8ZNiSARank= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tLh5e7xw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tLh5e7xw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2086AC116C6; Thu, 22 Jan 2026 16:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769098506; bh=SJFHQ6Dsh1f3ySZRRJ37Il23iv7ykfQoJASPEADlhj4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tLh5e7xwyLi35ByP+P/zx+FUIZG0/Y/cKNIGwGFiXAL/PUM7LOTUcK1jbPF0zrhbW QfWcHJziaTjycIc0UZky0Lxqkn5JXMqzA8amcf0V+QDYCC6W+IF0ubb4WgKlUZj5gc 2fhR+uq+lWXlGDORM4eoBcJ8MpPpG8puVbwZ4QnvuSU2bbfCDufoO668SdQkAa2w0Y m9HgVWsHLrT86aXF56xvPBBAM1ivknGyvZ3Z2g9KgKceVnABiMNnxJqLkQQy53rbvp 5weW0+uOX4bDc/i0DBPfurqkJVpfu0nO90iejA1w1Euge0UvXu/MHizO9U1La6QwEY GDcYIFh5457qg== Date: Thu, 22 Jan 2026 10:15:05 -0600 From: Bjorn Helgaas To: Frederic Weisbecker Cc: LKML , Michal =?utf-8?Q?Koutn=C3=BD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 23/33] PCI: Remove superfluous HK_TYPE_WQ check Message-ID: <20260122161505.GA1250310@bhelgaas> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260101221359.22298-24-frederic@kernel.org> On Thu, Jan 01, 2026 at 11:13:48PM +0100, Frederic Weisbecker wrote: > It doesn't make sense to use nohz_full without also isolating the > related CPUs from the domain topology, either through the use of > isolcpus= or cpuset isolated partitions. > > And now HK_TYPE_DOMAIN includes all kinds of domain isolated CPUs. > > This means that HK_TYPE_KERNEL_NOISE (of which HK_TYPE_WQ is only an > alias) should always be a subset of HK_TYPE_DOMAIN. > > Therefore sane configurations verify: > > HK_TYPE_KERNEL_NOISE | HK_TYPE_DOMAIN == HK_TYPE_DOMAIN > > Simplify the PCI probe target election accordingly. > > Signed-off-by: Frederic Weisbecker Acked-by: Bjorn Helgaas > --- > drivers/pci/pci-driver.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > index b902d8adf9a5..a9590601835a 100644 > --- a/drivers/pci/pci-driver.c > +++ b/drivers/pci/pci-driver.c > @@ -384,16 +384,9 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev, > pci_physfn_is_probed(dev)) { > error = local_pci_probe(&ddi); > } else { > - cpumask_var_t wq_domain_mask; > struct pci_probe_arg arg = { .ddi = &ddi }; > > - if (!zalloc_cpumask_var(&wq_domain_mask, GFP_KERNEL)) { > - error = -ENOMEM; > - goto out; > - } > - > INIT_WORK_ONSTACK(&arg.work, local_pci_probe_callback); > - > /* > * The target election and the enqueue of the work must be within > * the same RCU read side section so that when the workqueue pool > @@ -402,12 +395,9 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev, > * targets. > */ > rcu_read_lock(); > - cpumask_and(wq_domain_mask, > - housekeeping_cpumask(HK_TYPE_WQ), > - housekeeping_cpumask(HK_TYPE_DOMAIN)); > - > cpu = cpumask_any_and(cpumask_of_node(node), > - wq_domain_mask); > + housekeeping_cpumask(HK_TYPE_DOMAIN)); > + > if (cpu < nr_cpu_ids) { > struct workqueue_struct *wq = pci_probe_wq; > > @@ -422,10 +412,9 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev, > error = local_pci_probe(&ddi); > } > > - free_cpumask_var(wq_domain_mask); > destroy_work_on_stack(&arg.work); > } > -out: > + > dev->is_probed = 0; > cpu_hotplug_enable(); > return error; > -- > 2.51.1 >