public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Damien Dejean <dam.dejean@gmail.com>
Cc: andrew@lunn.ch, krzk+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
	pabeni@redhat.com, hkallweit1@gmail.com
Subject: Re: [PATCH v2 3/4] dt-bindings: net: realtek,rtl82xx: add a property to set MDI polarity
Date: Thu, 22 Jan 2026 10:51:02 -0600	[thread overview]
Message-ID: <20260122165102.GA2564919-robh@kernel.org> (raw)
In-Reply-To: <20260121151506.813783-3-dam.dejean@gmail.com>

On Wed, Jan 21, 2026 at 04:15:05PM +0100, Damien Dejean wrote:
> MDI pair polarity is usually configured by the bootloader.  However, on
> some designs the configuration is left untouched during boot and needs
> to be set by the driver.
> 
> Add the property 'realtek,mdi-cfg-polarity' to configure the polarity of
> each pair. Bit 0 to 3 configure the polarity or pairs A to D, if set to
> 1 the polarity is reversed for this pair.
> 
> Signed-off-by: Damien Dejean <dam.dejean@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> index c4ced671ecb8..17088c147358 100644
> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -61,6 +61,13 @@ properties:
>      description:
>        Force normal (0) or reverse (1) order of MDI pairs.
>  
> +  realtek,mdi-cfg-polarity:
> +    description:
> +      A bitmap to describe pair polarity swap. Bit 0 to swap polarity of pair A,
> +      bit 1 to swap polarity of pair B, bit 2 to swap polarity of pair C and bit
> +      3 to swap polarity of pair D.
> +    $ref: /schemas/types.yaml#/definitions/uint32

maximum: 0xf

However, are these properties something that should be common?

Rob

  reply	other threads:[~2026-01-22 16:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 15:15 [PATCH v2 1/4] dt-bindings: net: realtek,rtl82xx: add a property to set MDI order Damien Dejean
2026-01-21 15:15 ` [PATCH v2 2/4] net: phy: realtek: add RTL8224 pair order support Damien Dejean
2026-01-22 15:15   ` kernel test robot
2026-01-22 17:39   ` kernel test robot
2026-01-21 15:15 ` [PATCH v2 3/4] dt-bindings: net: realtek,rtl82xx: add a property to set MDI polarity Damien Dejean
2026-01-22 16:51   ` Rob Herring [this message]
2026-01-22 20:47     ` Damien Dejean
2026-01-22 23:06       ` Rob Herring
2026-01-21 15:15 ` [PATCH v2 4/4] net: phy: realtek: add RTL8224 polarity support Damien Dejean
2026-01-22 18:41   ` kernel test robot
2026-01-22 22:12   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122165102.GA2564919-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=dam.dejean@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox