From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0D616132A for ; Sat, 24 Jan 2026 03:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769224979; cv=none; b=ks4ddshN//+tO7OXIgSDvyxYbvtm75XCxvY6CurTcQQlrPjGHdm/5JasnsYxUsMVGoKKH1VJhBJA9oDuafVBe9yHm13jpAjomlH+qIv3qX8uCuv+7kbphI/TbfpeKfAs7YLwCp7yxqfUIjjQHHNFbWjHmZ9HI1IO/9zucX9i2f0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769224979; c=relaxed/simple; bh=hz4PGhjGMavgsH90Kj08u7Yi8vVczpJyk4hknyVJULA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nWb0jOgqGLry2QiRTuZGpo6fwsYeOugJJzMlPddG5juBO96k2ZIJA8BtxCJmybKu0kDhY5NRh6cQiYlbfGTeVd/8oNrVfge1FLbhavcFboHFdLdhb5rKlDJ2p9mm68Sd1zQHCPl/vMy22EKM1QN+QVIQsUyuQVfVfJrdtLffo44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y8aFMEDY; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y8aFMEDY" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-2ae2eb49b4bso6871406eec.0 for ; Fri, 23 Jan 2026 19:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769224977; x=1769829777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0oLk/yYsqWZDJCvnFpurWUS1lV8pRnDLAfMkKbWKpcg=; b=Y8aFMEDYbS2wDmWh5V+zSffScbHVSqLMOpK62THbXl33W/l5xc0gfupn/m+wvQ+ug/ Nmh9ZQDovO0C33aRziv2NoBxTUfl42leOqihecS36EWRfmzM6zS40XOcbUOUdxdEE7I+ Pq1wuj2NJy5YkVzP9ytuuJp2b7V1UEPy75vd5Aifio/cAwDGCvjmvsPvaSOxj/un+Ueb kESGhuRqSToT5Y+EZwSj73WguRTHeoKCIR4qz7EBfQMK5wRGr2EVADZpI1tZIdjyolZC QePs/m13aglKIqbY8w5xT0ofrWxn29/cUFvcxDgrVhvt7bTKYY14j32ICRASHB4mequ4 Ddmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769224977; x=1769829777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0oLk/yYsqWZDJCvnFpurWUS1lV8pRnDLAfMkKbWKpcg=; b=EQpWk+j+FJ2Yh6bF31HIz98JIEEOiLIsnZuUyUK/NNfsyzFTdnWgryvW+1r59zm6mp hbx78QdcKPmJuz5bXlt3vEwilnZwdRc55JsTguzLRpRVR1MjsQ07Kku99TjjYVz73L/9 K9vxMosiBb6bmnnHWrFbb0rd1JEZj6cYn1ApfGv7IrH6Z4CeJRdzLXK6Ih+vVssPBa3I t7bBWEMmG60465leY85V+dR4Y40d3X5MsUBifhNx0USFTHifgEJ4n5zGbqfv9CXZsbda hxftzHUMRhM1u5YHvKKGtcMcDofoO0gMUUkDbsl6jYOZ66smEJtCpvaZnW82saVIGO4B 5z2A== X-Gm-Message-State: AOJu0Yw68e4NKuWw7p2PHpZaZq3+zbhVT66v5Zi2z/OD6vijKpkgL6Kd S/Xr4UwdlooFGNWa8gJLYf+hQtHk6vw/HWnItmflfIC9uxklMqNO1HGmb+7RcWVO X-Gm-Gg: AZuq6aKkzGurcsMEX1a+CbkiQKHcEHkrz/iI04d991/e0BZMSQGsnPkfbqkDFAXTqac g8tfGya69tpGNcLs3+AbspFbeuLxe8FvGVDWnV+zppC3ovX/6k15SYuwcnZeZrocQdpk+1R1PwL 8yr1vrqa0zBRiTbgecFe63FplHwqG/9bTQG0UOVFPYP9abBbp6fxA8FokzE9AXl8Enm2FDESgft jngwgcwb+TAhygz7b1aXLgetYRQo46SQPNuafi95Y7JFuzYNJpa4EDjgz/FXDw5hyaFBPnmkZBO +rYS9HtqfphHcVZMEJwo/xXmWYdPllh65oyWHmv5VXW9wjhFrtHi9TILQATe5KucG5s1HtcGZ7R FOIGRNBp6jIGnEEoh7jU6WCqT8esa5eDJAJ3xbmPiXG3QP2N3AzLKK+HjkJIWKz2KGB9ihv4zPj 61YPYboBln9siNemIpV/hHMGxhTQKF9jVtjfuiFhGjSo5LzOmd4qH4/zRD6jhwAFswyaLNY3ltK 8cDjBDg8vU0j6UJgQKVPFjUS37zJ9GUihsByduxUWx/Y3rmanRHpyeMdM7xXs3fdew7VmNW+KEO U+9z X-Received: by 2002:a05:7301:fa87:b0:2ae:5b01:bfa5 with SMTP id 5a478bee46e88-2b739bb249emr2963832eec.32.1769224977502; Fri, 23 Jan 2026 19:22:57 -0800 (PST) Received: from ethan-latitude5420.. (host-127-24.cafrjco.fresno.ca.us.clients.pavlovmedia.net. [68.180.127.24]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa03fd0sm5540278eec.23.2026.01.23.19.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 19:22:57 -0800 (PST) From: Ethan Nelson-Moore To: netdev@vger.kernel.org, linux-usb@vger.kernel.org Cc: Ethan Nelson-Moore , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Korsgaard , Simon Horman Subject: [PATCH net-next] net: usb: sr9700: replace magic numbers with register bit macros Date: Fri, 23 Jan 2026 19:22:43 -0800 Message-ID: <20260124032248.26807-1-enelsonmoore@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The first byte of the Rx frame is a copy of the Rx status register, so 0x40 corresponds to RSR_MF (meaning the frame is multicast). Replace 0x40 with RSR_MF for clarity. (All other bits of the RSR indicate errors. The fact that the driver ignores these errors will be fixed by a later patch.) The first byte of the status URB is a copy of the NSR, so 0x40 corresponds to NSR_LINKST. Replace 0x40 with NSR_LINKST for clarity. Signed-off-by: Ethan Nelson-Moore --- drivers/net/usb/sr9700.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 9c7cd0db1768..8ffd2391e6d7 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -366,7 +366,7 @@ static int sr9700_rx_fixup(struct usbnet *dev, struct sk_buff *skb) /* one skb may contains multiple packets */ while (skb->len > SR_RX_OVERHEAD) { - if (skb->data[0] != 0x40) + if (skb->data[0] != RSR_MF) return 0; /* ignore the CRC length */ @@ -455,7 +455,7 @@ static void sr9700_status(struct usbnet *dev, struct urb *urb) buf = urb->transfer_buffer; - link = !!(buf[0] & 0x40); + link = !!(buf[0] & NSR_LINKST); sr9700_handle_link_change(dev->net, link); } -- 2.43.0