From: Vladimir Oltean <olteanv@gmail.com>
To: Yangfl <mmyangfl@gmail.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: dsa: yt921x: Add DCB/priority support
Date: Sat, 24 Jan 2026 10:37:01 +0200 [thread overview]
Message-ID: <20260124083701.ihffncswmoe6fw5k@skbuf> (raw)
In-Reply-To: <CAAXyoMOfMPzSAqePyiFLRx-Cth3LDq2f20TY+GpXOaVW-p-vRg@mail.gmail.com>
On Sat, Jan 24, 2026 at 10:05:58AM +0800, Yangfl wrote:
> On Sat, Jan 24, 2026 at 7:48 AM Vladimir Oltean <olteanv@gmail.com> wrote:
> >
> > Are you sure the "port" selector represents the Ethernet port default
> > priority? It seems odd for it to have any other trust order in hardware
> > than last. What would be the use case for that? Sure it's not an L4 port,
> > which could be mapped over IEEE_8021QAZ_APP_SEL_ANY?
> >
>
> No (with the "port" selector) but I'm wondering, do we have
> corresponding port prio methods
> port_add_stream_prio()/port_add_dgram_prio() or something like?
No, but it doesn't mean dsa_user_dcbnl_ieee_setapp() can't be extended
with the IEEE_8021QAZ_APP_SEL_ANY selector if necessary. I wouldn't
bother to do that just for testing, though, just hack something up to
determine what it's about.
next prev parent reply other threads:[~2026-01-24 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 19:42 [PATCH net-next v2 0/2] net: dsa: yt921x: Add DCB/priority support David Yang
2026-01-22 19:42 ` [PATCH net-next v2 1/2] net: dsa: tag_yt921x: fix priority support David Yang
2026-01-22 19:42 ` [PATCH net-next v2 2/2] net: dsa: yt921x: Add DCB/priority support David Yang
2026-01-23 23:47 ` Vladimir Oltean
2026-01-24 2:05 ` Yangfl
2026-01-24 8:37 ` Vladimir Oltean [this message]
2026-01-24 10:02 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260124083701.ihffncswmoe6fw5k@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox