From: Gal Pressman <gal@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>
Cc: Igor Russkikh <irusskikh@marvell.com>,
Boris Pismenny <borisp@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, David Ahern <dsahern@kernel.org>,
Simon Horman <horms@kernel.org>,
Alexander Duyck <alexanderduyck@fb.com>,
<linux-rdma@vger.kernel.org>, Gal Pressman <gal@nvidia.com>
Subject: [PATCH net-next 0/3] Single MSS length in UDP GSO_PARTIAL
Date: Sun, 25 Jan 2026 14:16:46 +0200 [thread overview]
Message-ID: <20260125121649.778086-1-gal@nvidia.com> (raw)
This series addresses an inconsistency in how UDP GSO_PARTIAL handles
the UDP header length field.
Currently, when GSO_PARTIAL segmentation is used, the UDP header length
contains the large MSS size, requiring drivers to manually adjust it
before transmitting. This is inconsistent with how tunnel GSO_PARTIAL
handles outer headers in UDP tunnels, where the length is set to the
single segment size.
This was originally suggested by Alexander Duyck back in 2018:
https://lore.kernel.org/netdev/CAKgT0UcdnUWgr3KQ=RnLKigokkiUuYefmL-ePpDvJOBNpKScFA@mail.gmail.com/
The first patch fixes the core UDP offload code to set the UDP length
field to the single segment size (gso_size + UDP header) instead of the
large MSS size. This provides hardware with a proper template length
value for final segmentation.
The subsequent patches remove the now redundant UDP header length
adjustments from the mlx5e and aquantia drivers, as the core code now
handles this correctly.
I couldn't find any other drivers that support UDP GSO_PARTIAL; idpf
supports UDP segmentation, but it does not use GSO_PARTIAL.
Gal Pressman (3):
udp: gso: Use single MSS length in UDP header for GSO_PARTIAL
net/mlx5e: Remove redundant UDP length adjustment with GSO_PARTIAL
net: aquantia: Remove redundant UDP length adjustment with GSO_PARTIAL
drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3 ---
.../mellanox/mlx5/core/en_accel/en_accel.h | 17 -----------------
net/ipv4/udp_offload.c | 6 ++++--
3 files changed, 4 insertions(+), 22 deletions(-)
--
2.40.1
next reply other threads:[~2026-01-25 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 12:16 Gal Pressman [this message]
2026-01-25 12:16 ` [PATCH net-next 1/3] udp: gso: Use single MSS length in UDP header for GSO_PARTIAL Gal Pressman
2026-01-26 17:53 ` Willem de Bruijn
2026-02-03 12:20 ` Alice Mikityanska
2026-02-03 13:51 ` Gal Pressman
2026-02-04 12:47 ` Alice Mikityanska
2026-01-25 12:16 ` [PATCH net-next 2/3] net/mlx5e: Remove redundant UDP length adjustment with GSO_PARTIAL Gal Pressman
2026-01-27 7:50 ` Tariq Toukan
2026-01-25 12:16 ` [PATCH net-next 3/3] net: aquantia: " Gal Pressman
2026-01-28 1:40 ` [PATCH net-next 0/3] Single MSS length in UDP GSO_PARTIAL patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260125121649.778086-1-gal@nvidia.com \
--to=gal@nvidia.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox