From: Bjorn Helgaas <helgaas@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-pci@vger.kernel.org, linux-mips@vger.kernel.org,
linux-s390@vger.kernel.org, rust-for-linux@vger.kernel.org,
"Jon Mason" <jdmason@kudzu.us>,
"Jonathan Corbet" <corbet@lwn.net>,
"Linas Vepstas" <linasvepstas@gmail.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Danilo Krummrich" <dakr@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Martin Kepplinger-Novaković" <martink@posteo.de>,
"Pavel Machek" <pavel@ucw.cz>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Mengyuan Lou" <mengyuanlou@net-swift.com>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>, "Takashi Iwai" <tiwai@suse.de>,
"Eric Biggers" <ebiggers@google.com>,
"Madadi Vineeth Reddy" <vineethr@linux.ibm.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Frederic Barrat" <fbarrat@linux.ibm.com>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Dong Yibo" <dong100@mucse.com>,
"Lukas Bulwahn" <lukas.bulwahn@redhat.com>,
"Vivian Wang" <wangruikang@iscas.ac.cn>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>
Subject: Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused driver
Date: Sun, 25 Jan 2026 12:11:25 -0600 [thread overview]
Message-ID: <20260125181125.GA209392@bhelgaas> (raw)
In-Reply-To: <CADkSEUjyXH74izTrsfhdAjh=n-jnGx=tXbqPx86M9OYqjXj0PA@mail.gmail.com>
On Sat, Jan 24, 2026 at 03:32:17PM -0800, Ethan Nelson-Moore wrote:
> On Fri, Jan 23, 2026 at 11:25 PM Christophe Leroy (CS GROUP)
> <chleroy@kernel.org> wrote:
> > Yes and that's exactly the reason why removing unused IDs will be a problem.
> >
> > Let's take an exemple: some patch adds PCI_DEVICE_ID_ARECA_1682 after
> > PCI_DEVICE_ID_ARECA_1681 in pci_ids.h in the mainline. That patch needs
> > to be backported and it conflicts with PCI_VENDOR_ID_S2IO which is not
> > anymore in the mainline but is still in stable.
>
> Hi, Christophe,
>
> I understand your reasoning now. Thanks for clarifying. In my opinion,
> changes to pci_ids.h don't happen often enough for that to be a
> problem. Unused IDs have been removed from it before.
What is the value in removing the IDs?
The values can never be reused for new hardware, so removal doesn't
make room for anything in the future. Unlike the removal of driver
code, removing the IDs doesn't reduce complexity or improve
readability or maintainability.
next prev parent reply other threads:[~2026-01-25 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 3:30 [PATCH net-next] net: ethernet: neterion: s2io: remove unused driver Ethan Nelson-Moore
2026-01-23 18:11 ` Bjorn Helgaas
2026-01-24 2:01 ` Ethan Nelson-Moore
2026-01-24 7:24 ` Christophe Leroy (CS GROUP)
2026-01-24 23:32 ` Ethan Nelson-Moore
2026-01-25 18:11 ` Bjorn Helgaas [this message]
2026-01-25 21:41 ` Ethan Nelson-Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260125181125.GA209392@bhelgaas \
--to=helgaas@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=fbarrat@linux.ibm.com \
--cc=gary@garyguo.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=jdmason@kudzu.us \
--cc=kuba@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linasvepstas@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lossin@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=martink@posteo.de \
--cc=mengyuanlou@net-swift.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=oohall@gmail.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pavel@ucw.cz \
--cc=rust-for-linux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=tiwai@suse.de \
--cc=tmgross@umich.edu \
--cc=tsbogend@alpha.franken.de \
--cc=tytso@mit.edu \
--cc=vadim.fedorenko@linux.dev \
--cc=vineethr@linux.ibm.com \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox