From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 581F51DDC3F; Sun, 25 Jan 2026 18:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769364687; cv=none; b=Ql2T7YaLkM2+Pm6BrMOkqgPuFdP2v9TNB8Fqo3XS/XE8b/+l9iWc/vUE9pMBXric3BTOKsHMg491aQ7LqK23lrgXLAef7RtC4Ybi/Odxap4bf0ftSnKHabL8mNBv4bBFlEWpbTz637P0CR1BQSdMfqNt/7GAvYclRcIwlyhDusg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769364687; c=relaxed/simple; bh=qgVtO8mWSRuxFs90xJYzoTYRLOJL+pr5SZ3KzZGHvdk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=JrBl8NqOHqK/+j7aHq721HekzwPww8lzJE8c7RS/tLIqqwwc30YLXyEAb51V5OTuQoJH16wNfdVWLnIpZWwBNVeNUYDOtS0kFSb1T1AxiWednqEGG71jV/br1DwUP5oQrLjXWrRjMWztBidI5JTVLis24RaWJlzrHzKZuC+xejQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fSXPgBM6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fSXPgBM6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFF50C4CEF1; Sun, 25 Jan 2026 18:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769364687; bh=qgVtO8mWSRuxFs90xJYzoTYRLOJL+pr5SZ3KzZGHvdk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fSXPgBM6pyKu6dxW7/SPJOT2E4JeiGkQ610PJjUqTKkJD9/f6FdXDhiGS/C9infEx NjqBQ+VPIKS16IbneeZpeiRn3dBNpjmUKDKCm9NK0GT4y2zfbjmuo+gQ6x1UmoXMTD kZz2Irh3PGvFPBoVFaVH+V3BFLlM+GH3c0KBgTuGpNwBKg5MJWfMWSlJbD0UIfkwg5 DKDEIsbflP87ympyOXbQ3AF+c2uoO5v7DXWIhl6viE/qlEoW0SJxIRMkuV34fF3QjY jWtTRONGo64Ey2japsnD7I9qrRXOkuY7b6Ww8c/lrOxcIhdtkuaKfpAI/o6fDzgsqu Y3/fmBHYDsx6w== Date: Sun, 25 Jan 2026 12:11:25 -0600 From: Bjorn Helgaas To: Ethan Nelson-Moore Cc: "Christophe Leroy (CS GROUP)" , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, rust-for-linux@vger.kernel.org, Jon Mason , Jonathan Corbet , Linas Vepstas , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Thomas Bogendoerfer , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andrew Lunn , Danilo Krummrich , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Andrew Morton , Martin =?utf-8?Q?Kepplinger-Novakovi=C4=87?= , Pavel Machek , MD Danish Anwar , Mengyuan Lou , Pablo Neira Ayuso , Huacai Chen , Theodore Ts'o , Takashi Iwai , Eric Biggers , Madadi Vineeth Reddy , Ard Biesheuvel , "Martin K. Petersen" , Frederic Barrat , Andrew Donnellan , Herbert Xu , Vadim Fedorenko , Lorenzo Bianconi , Dong Yibo , Lukas Bulwahn , Vivian Wang , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused driver Message-ID: <20260125181125.GA209392@bhelgaas> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jan 24, 2026 at 03:32:17PM -0800, Ethan Nelson-Moore wrote: > On Fri, Jan 23, 2026 at 11:25 PM Christophe Leroy (CS GROUP) > wrote: > > Yes and that's exactly the reason why removing unused IDs will be a problem. > > > > Let's take an exemple: some patch adds PCI_DEVICE_ID_ARECA_1682 after > > PCI_DEVICE_ID_ARECA_1681 in pci_ids.h in the mainline. That patch needs > > to be backported and it conflicts with PCI_VENDOR_ID_S2IO which is not > > anymore in the mainline but is still in stable. > > Hi, Christophe, > > I understand your reasoning now. Thanks for clarifying. In my opinion, > changes to pci_ids.h don't happen often enough for that to be a > problem. Unused IDs have been removed from it before. What is the value in removing the IDs? The values can never be reused for new hardware, so removal doesn't make room for anything in the future. Unlike the removal of driver code, removing the IDs doesn't reduce complexity or improve readability or maintainability.