* [PATCH net-next] net: usb: int51x1: remove unused includes
@ 2026-01-26 7:06 Ethan Nelson-Moore
2026-01-28 2:01 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-26 7:06 UTC (permalink / raw)
To: netdev, linux-usb
Cc: Ethan Nelson-Moore, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Most of the headers the int51x1 driver includes are not actually used.
Remove these unused includes.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/usb/int51x1.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/usb/int51x1.c b/drivers/net/usb/int51x1.c
index 6fde41550de1..317ae365277f 100644
--- a/drivers/net/usb/int51x1.c
+++ b/drivers/net/usb/int51x1.c
@@ -13,13 +13,8 @@
*/
#include <linux/module.h>
-#include <linux/ctype.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
-#include <linux/ethtool.h>
-#include <linux/slab.h>
-#include <linux/mii.h>
-#include <linux/usb.h>
#include <linux/usb/usbnet.h>
#define INT51X1_VENDOR_ID 0x09e1
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: usb: int51x1: remove unused includes
2026-01-26 7:06 [PATCH net-next] net: usb: int51x1: remove unused includes Ethan Nelson-Moore
@ 2026-01-28 2:01 ` Jakub Kicinski
2026-01-28 2:11 ` Ethan Nelson-Moore
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2026-01-28 2:01 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: netdev, linux-usb, Andrew Lunn, David S. Miller, Eric Dumazet,
Paolo Abeni
On Sun, 25 Jan 2026 23:06:13 -0800 Ethan Nelson-Moore wrote:
> -#include <linux/usb.h>
$ git grep 'struct usb_driver {'
include/linux/usb.h:struct usb_driver {
Please do not send v2 of this one.
--
pw-bot: reject
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: usb: int51x1: remove unused includes
2026-01-28 2:01 ` Jakub Kicinski
@ 2026-01-28 2:11 ` Ethan Nelson-Moore
0 siblings, 0 replies; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-28 2:11 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev, linux-usb, Andrew Lunn, David S. Miller, Eric Dumazet,
Paolo Abeni
On Tue, Jan 27, 2026 at 6:01 PM Jakub Kicinski <kuba@kernel.org> wrote:
> $ git grep 'struct usb_driver {'
> include/linux/usb.h:struct usb_driver {
Good point. I'll try to avoid introducing indirect header dependencies
in the future.
> Please do not send v2 of this one.
Understandable. This kind of trivial cleanup isn't really necessary
anyway; I just happened to notice the unused includes.
Ethan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-28 2:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 7:06 [PATCH net-next] net: usb: int51x1: remove unused includes Ethan Nelson-Moore
2026-01-28 2:01 ` Jakub Kicinski
2026-01-28 2:11 ` Ethan Nelson-Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox