From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A831F2380 for ; Mon, 26 Jan 2026 13:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769435458; cv=none; b=b2LO8EqqLy0npMDOTpgRGNdQnmWg0T9ZGYW5w5B925VI8gPo3g1lNJMlngGBTuvifp4m36UHEOoFZwjEvHRxavasuBM48oBcDeoI60dYxD8y5uwYwS9XUBUkVfFJolZcxwjGg0wv5bVHF0tg+CuNLqbgW+ygEOBtjY/rfWoKbmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769435458; c=relaxed/simple; bh=f53timH0np4bz+gztyV/dfAq6Ha3g4qBItMHfYuFoN4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JpIe70nm+RHwiS+VbJI0Noph+o1FBB9awygeBiS6/MWJLuqVojR8x8g2FDtW+6yzTSbr/fHBNPUTORbVgZjYqCddAT+wJG+AORsSE4z01nZJ1AAhzZY/Gm3HnFsxFIhalZVD7cJnTf9FWx1WTogQnLIkb0hHvX3MYNTFDdaFNgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z896Cdtp; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z896Cdtp" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8c6aaf3cd62so580103385a.3 for ; Mon, 26 Jan 2026 05:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769435456; x=1770040256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iQxwi2pFUZR+UAlToTQBrAAHIAjqCBSvDHQE8e6QSYI=; b=Z896CdtpOPVagWYpaW3ZkjtlZsDBCg2opIPR+XJms3UMQNd3qOb7KXjj61LSp110Sx 9V/rHLr+O61Ofv51xDoPDDd940XnAkc20xlJpVk8oTjGlYqZuEdSwA28pjkLBzN5YfAp zcGPPFGkanNVnBoSIbFVHcVXejUySsHfG4728ow6+dgE5VDB//LuFzDmGpfqbYDCT2Km Qnr/1XJyJXp9ePkujuiWX2kDEhejrhcCsBZgyTjlk78MpuXKrLw8SWH3sizps4oUQQpX YELNukHAWlMy9XvMIPdDtLHDJclQujtXGCkMladbAFli7aZBxfKXWYxYhBu67d24OpcP 2l3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769435456; x=1770040256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iQxwi2pFUZR+UAlToTQBrAAHIAjqCBSvDHQE8e6QSYI=; b=wHHjmtYOg0yeoiRAQN58kDTwzcIvoqoTtGbmy3HsA0Kd/tUf0WSpQLo9auhSUNDnXg jagZzMcWFGcJ9HZOlqlJpDmNjO2J+6+XBOWVDjWJ6ccVYsgNcnwmPq5unKjrvQU+sM0G DlLYktKduhYP3K2bY3bU7rrna3zg64OjXaSQXrz4Mu9Z2V1ep0N+lxpKJFFogdj53vEp v79YxxmGvEZhOE5gzG8HoeJF2cor+Veo38/GwxSvljfkn5m8/qQvdQdsiBmPjR1A7QJc fEwz4E+3nJ+DQsBoZoLL2KWiWrGPnRBwQswaZpcgKG+4nqZ06TcT5pC0yjBhBpN6OIrK e13w== X-Forwarded-Encrypted: i=1; AJvYcCUYeWwmoNJoSj/vLFO0SivGJF1lTaxLKPFh6Y0kw1c+VGsH9s2MepR7s7D7qnwaHxZvTirCWfw=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ0kEYau6A3RzPht6WViNM9ELre0HEAVLTUQzamwptnirfWQ5+ dhtFRR10gAZorPFbrXmvDbzCtHQQ1Oa/6CgRXcKMM01D5xtrqJOoJIdA X-Gm-Gg: AZuq6aIGRt7BUu1hU1plvoWCRwcwmgXYG5BgZVlYn339avIuK+8U4tlM7Eobrzh1OUV joc2rHal1tKgwAQTmfoI5ZzBjYaZLN3IRo6I9VtQf5xdM5xpdaKVYcTQHtj12WDx9FhLcZPsi0M BUg8uqw+9ms9LjhJ8QToh7pO3jZ9kPIoZWcPMpY/GmCWjR6C3I40oMsQ+Eo9lMyq+VCTIzWfBuZ jRSn9COM8mHNu6ufFmFLCo99C6dG+zDmxaUqSSPLlKb1FdSh5obBKLTy+OP9fE0GlMxZx8T1C/Q 7ZggjQywoWp0pSBnAYzz2fCq0nzbHUEfi7YXGpS6V8euWKTlBbdtvYzc+AxRXZAQ7fAmEJGuBfs aErhg3pF49t9DMe2qczlVKvwQA2pNswwyvNTUK58P2rgLhu5y8Gvw3cMJviyNRY6bgvpZsmWzkG 86jvNzrNaN48yyGMUhDyQ= X-Received: by 2002:a05:6a00:22d3:b0:81f:4c37:7647 with SMTP id d2e1a72fcca58-823412dbea7mr4104835b3a.68.1769427926560; Mon, 26 Jan 2026 03:45:26 -0800 (PST) Received: from soham-laptop.. ([103.182.158.109]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82318648dd7sm9086663b3a.3.2026.01.26.03.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 03:45:26 -0800 (PST) From: Soham Metha To: linux-kernel-mentees@lists.linuxfoundation.org Cc: shuah@kernel.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, syzbot+619b9ef527f510a57cfc@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, martin.lau@linux.dev, sdf@fomichev.me, song@kernel.org, yonghong.song@linux.dev, Soham Metha , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jason Xing , Kuniyuki Iwashima , Michal Luczaj , Mina Almasry , Eric Biggers , Alexander Lobakin , netdev@vger.kernel.org Subject: [PATCH v2] net: skbuff: fix uninitialized memory use in pskb_expand_head() Date: Mon, 26 Jan 2026 17:13:30 +0530 Message-Id: <20260126114332.23955-1-sohammetha01@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <6954bc70.050a0220.a1b6.0310.GAE@google.com> References: <6954bc70.050a0220.a1b6.0310.GAE@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pskb_expand_head() allocates a new skb data buffer using kmalloc_reserve(), which does not initialize memory. skb helpers may later copy or move padding bytes from the buffer. Initialize the newly allocated skb buffer to avoid propagating uninitialized memory. Reported-by: syzbot+619b9ef527f510a57cfc@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=619b9ef527f510a57cfc Tested-by: syzbot+619b9ef527f510a57cfc@syzkaller.appspotmail.com Signed-off-by: Soham Metha --- v2: - No code changes - Resent to netdev list - Added Closes tag - Added Tested-by tag net/core/skbuff.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index a56133902c0d..b0f0d3a0310b 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -2282,6 +2282,9 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, data = kmalloc_reserve(&size, gfp_mask, NUMA_NO_NODE, NULL); if (!data) goto nodata; + + memset(data, 0, size); + size = SKB_WITH_OVERHEAD(size); /* Copy only real data... and, alas, header. This should be -- 2.34.1