* [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
@ 2026-01-26 14:46 Brian Vazquez
2026-01-26 16:24 ` Andrew Lunn
2026-01-26 17:28 ` Paul Menzel
0 siblings, 2 replies; 9+ messages in thread
From: Brian Vazquez @ 2026-01-26 14:46 UTC (permalink / raw)
To: Brian Vazquez, Tony Nguyen, Przemek Kitszel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan
Cc: David Decotigny, Li Li, Anjali Singhai, Sridhar Samudrala,
linux-kernel, netdev, emil.s.tantilov, Brian Vazquez,
Brett Creeley, Aleksandr Loktionov
The code uses the vidx for the IRQ name but that doesn't match ethtool
reporting or netdev naming, this makes it hard to tune the device and
associate queues with IRQs. Sequentially requesting irqs starting from
'0' makes the output consistent.
Before:
ethtool -L eth1 tx 1 combined 3
grep . /proc/irq/*/*idpf*/../smp_affinity_list
/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
/proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
/proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
/proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
/proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
ethtool -S eth1 | grep -v ': 0'
NIC statistics:
tx_q-0_pkts: 1002
tx_q-1_pkts: 2679
tx_q-2_pkts: 1113
tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
rx_q-0_pkts: 1143
rx_q-1_pkts: 3172
rx_q-2_pkts: 1074
After:
ethtool -L eth1 tx 1 combined 3
grep . /proc/irq/*/*idpf*/../smp_affinity_list
/proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
/proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
/proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
/proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
/proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
ethtool -S eth1 | grep -v ': 0'
NIC statistics:
tx_q-0_pkts: 118
tx_q-1_pkts: 134
tx_q-2_pkts: 228
tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
rx_q-0_pkts: 111
rx_q-1_pkts: 366
rx_q-2_pkts: 120
Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Signed-off-by: Brian Vazquez <brianvv@google.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
V2: Add mising Fixes tag
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
index c2a1fe3c79ec..c1f8dfc570ce 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
@@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport,
continue;
name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name,
- vec_name, vidx);
+ vec_name, vector);
err = request_irq(irq_num, idpf_vport_intr_clean_queues, 0,
name, q_vector);
--
2.52.0.457.g6b5491de43-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 14:46 [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering Brian Vazquez
@ 2026-01-26 16:24 ` Andrew Lunn
2026-01-26 17:40 ` Brian Vazquez
2026-01-26 17:28 ` Paul Menzel
1 sibling, 1 reply; 9+ messages in thread
From: Andrew Lunn @ 2026-01-26 16:24 UTC (permalink / raw)
To: Brian Vazquez
Cc: Brian Vazquez, Tony Nguyen, Przemek Kitszel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
David Decotigny, Li Li, Anjali Singhai, Sridhar Samudrala,
linux-kernel, netdev, emil.s.tantilov, Brett Creeley,
Aleksandr Loktionov
On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
> The code uses the vidx for the IRQ name but that doesn't match ethtool
> reporting or netdev naming, this makes it hard to tune the device and
> associate queues with IRQs. Sequentially requesting irqs starting from
> '0' makes the output consistent.
>
> Before:
>
> ethtool -L eth1 tx 1 combined 3
>
> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
>
> ethtool -S eth1 | grep -v ': 0'
> NIC statistics:
> tx_q-0_pkts: 1002
> tx_q-1_pkts: 2679
> tx_q-2_pkts: 1113
> tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> rx_q-0_pkts: 1143
> rx_q-1_pkts: 3172
> rx_q-2_pkts: 1074
>
> After:
>
> ethtool -L eth1 tx 1 combined 3
>
> grep . /proc/irq/*/*idpf*/../smp_affinity_list
>
> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
>
> ethtool -S eth1 | grep -v ': 0'
> NIC statistics:
> tx_q-0_pkts: 118
> tx_q-1_pkts: 134
> tx_q-2_pkts: 228
> tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> rx_q-0_pkts: 111
> rx_q-1_pkts: 366
> rx_q-2_pkts: 120
Are there any ABI issues here?
Andrew
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 14:46 [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering Brian Vazquez
2026-01-26 16:24 ` Andrew Lunn
@ 2026-01-26 17:28 ` Paul Menzel
1 sibling, 0 replies; 9+ messages in thread
From: Paul Menzel @ 2026-01-26 17:28 UTC (permalink / raw)
To: Brian Vazquez, Brian Vazquez
Cc: Tony Nguyen, Przemek Kitszel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, intel-wired-lan, David Decotigny,
Li Li, Anjali Singhai, Sridhar Samudrala, linux-kernel, netdev,
emil.s.tantilov, Brett Creeley, Aleksandr Loktionov
Dear Brian,
Thank you for your patch.
Am 26.01.26 um 15:46 schrieb Brian Vazquez via Intel-wired-lan:
> The code uses the vidx for the IRQ name but that doesn't match ethtool
> reporting or netdev naming, this makes it hard to tune the device and
> associate queues with IRQs. Sequentially requesting irqs starting from
> '0' makes the output consistent.
>
> Before:
>
> ethtool -L eth1 tx 1 combined 3
>
> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
>
> ethtool -S eth1 | grep -v ': 0'
> NIC statistics:
> tx_q-0_pkts: 1002
> tx_q-1_pkts: 2679
> tx_q-2_pkts: 1113
> tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> rx_q-0_pkts: 1143
> rx_q-1_pkts: 3172
> rx_q-2_pkts: 1074
>
> After:
>
> ethtool -L eth1 tx 1 combined 3
>
> grep . /proc/irq/*/*idpf*/../smp_affinity_list
>
> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
>
> ethtool -S eth1 | grep -v ': 0'
> NIC statistics:
> tx_q-0_pkts: 118
> tx_q-1_pkts: 134
> tx_q-2_pkts: 228
> tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> rx_q-0_pkts: 111
> rx_q-1_pkts: 366
> rx_q-2_pkts: 120
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> Signed-off-by: Brian Vazquez <brianvv@google.com>
> Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> ---
> V2: Add mising Fixes tag
>
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index c2a1fe3c79ec..c1f8dfc570ce 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport,
> continue;
>
> name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name,
> - vec_name, vidx);
> + vec_name, vector);
>
> err = request_irq(irq_num, idpf_vport_intr_clean_queues, 0,
> name, q_vector);
With Andrew’s comment addressed in the commit message, this looks sensible.
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 16:24 ` Andrew Lunn
@ 2026-01-26 17:40 ` Brian Vazquez
2026-01-26 17:53 ` Andrew Lunn
0 siblings, 1 reply; 9+ messages in thread
From: Brian Vazquez @ 2026-01-26 17:40 UTC (permalink / raw)
To: Andrew Lunn
Cc: Brian Vazquez, Tony Nguyen, Przemek Kitszel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
David Decotigny, Li Li, Anjali Singhai, Sridhar Samudrala,
linux-kernel, netdev, emil.s.tantilov, Brett Creeley,
Aleksandr Loktionov
On Mon, Jan 26, 2026 at 11:24 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
> > The code uses the vidx for the IRQ name but that doesn't match ethtool
> > reporting or netdev naming, this makes it hard to tune the device and
> > associate queues with IRQs. Sequentially requesting irqs starting from
> > '0' makes the output consistent.
> >
> > Before:
> >
> > ethtool -L eth1 tx 1 combined 3
> >
> > grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> > /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> > /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> > /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
> >
> > ethtool -S eth1 | grep -v ': 0'
> > NIC statistics:
> > tx_q-0_pkts: 1002
> > tx_q-1_pkts: 2679
> > tx_q-2_pkts: 1113
> > tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> > rx_q-0_pkts: 1143
> > rx_q-1_pkts: 3172
> > rx_q-2_pkts: 1074
> >
> > After:
> >
> > ethtool -L eth1 tx 1 combined 3
> >
> > grep . /proc/irq/*/*idpf*/../smp_affinity_list
> >
> > /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> > /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> > /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> > /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
> >
> > ethtool -S eth1 | grep -v ': 0'
> > NIC statistics:
> > tx_q-0_pkts: 118
> > tx_q-1_pkts: 134
> > tx_q-2_pkts: 228
> > tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> > rx_q-0_pkts: 111
> > rx_q-1_pkts: 366
> > rx_q-2_pkts: 120
>
> Are there any ABI issues here?
The patch doesn't change the format, it just fixes the numbering in
the name to make it consistent with other reporting tools. It
shouldn't break any library.
> Andrew
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 17:40 ` Brian Vazquez
@ 2026-01-26 17:53 ` Andrew Lunn
2026-01-26 20:46 ` [Intel-wired-lan] " Jacob Keller
0 siblings, 1 reply; 9+ messages in thread
From: Andrew Lunn @ 2026-01-26 17:53 UTC (permalink / raw)
To: Brian Vazquez
Cc: Brian Vazquez, Tony Nguyen, Przemek Kitszel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
David Decotigny, Li Li, Anjali Singhai, Sridhar Samudrala,
linux-kernel, netdev, emil.s.tantilov, Brett Creeley,
Aleksandr Loktionov
On Mon, Jan 26, 2026 at 12:40:15PM -0500, Brian Vazquez wrote:
> On Mon, Jan 26, 2026 at 11:24 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
> > > The code uses the vidx for the IRQ name but that doesn't match ethtool
> > > reporting or netdev naming, this makes it hard to tune the device and
> > > associate queues with IRQs. Sequentially requesting irqs starting from
> > > '0' makes the output consistent.
> > >
> > > Before:
> > >
> > > ethtool -L eth1 tx 1 combined 3
> > >
> > > grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > > /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > > /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> > > /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> > > /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> > > /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
> > >
> > > ethtool -S eth1 | grep -v ': 0'
> > > NIC statistics:
> > > tx_q-0_pkts: 1002
> > > tx_q-1_pkts: 2679
> > > tx_q-2_pkts: 1113
> > > tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> > > rx_q-0_pkts: 1143
> > > rx_q-1_pkts: 3172
> > > rx_q-2_pkts: 1074
> > >
> > > After:
> > >
> > > ethtool -L eth1 tx 1 combined 3
> > >
> > > grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > >
> > > /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > > /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> > > /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> > > /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> > > /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
> > >
> > > ethtool -S eth1 | grep -v ': 0'
> > > NIC statistics:
> > > tx_q-0_pkts: 118
> > > tx_q-1_pkts: 134
> > > tx_q-2_pkts: 228
> > > tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> > > rx_q-0_pkts: 111
> > > rx_q-1_pkts: 366
> > > rx_q-2_pkts: 120
> >
> > Are there any ABI issues here?
>
> The patch doesn't change the format, it just fixes the numbering in
> the name to make it consistent with other reporting tools. It
> shouldn't break any library.
But is the numbering part of the ABI?
Making a comment about ABI in the commit message makes it clear it is
something you have considered, and you have decided it is not an
issue. If there is no such comment, reviewers probably should ask.
Andrew
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 17:53 ` Andrew Lunn
@ 2026-01-26 20:46 ` Jacob Keller
2026-01-26 20:51 ` Eric Dumazet
0 siblings, 1 reply; 9+ messages in thread
From: Jacob Keller @ 2026-01-26 20:46 UTC (permalink / raw)
To: Andrew Lunn, Brian Vazquez
Cc: Brian Vazquez, Tony Nguyen, Przemek Kitszel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
David Decotigny, Li Li, Anjali Singhai, Sridhar Samudrala,
linux-kernel, netdev, emil.s.tantilov, Brett Creeley,
Aleksandr Loktionov
On 1/26/2026 9:53 AM, Andrew Lunn wrote:
> On Mon, Jan 26, 2026 at 12:40:15PM -0500, Brian Vazquez wrote:
>> On Mon, Jan 26, 2026 at 11:24 AM Andrew Lunn <andrew@lunn.ch> wrote:
>>>
>>> On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
>>>> The code uses the vidx for the IRQ name but that doesn't match ethtool
>>>> reporting or netdev naming, this makes it hard to tune the device and
>>>> associate queues with IRQs. Sequentially requesting irqs starting from
>>>> '0' makes the output consistent.
>>>>
>>>> Before:
>>>>
>>>> ethtool -L eth1 tx 1 combined 3
>>>>
>>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
>>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
>>>> /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
>>>> /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
>>>> /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
>>>> /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
>>>>
>>>> ethtool -S eth1 | grep -v ': 0'
>>>> NIC statistics:
>>>> tx_q-0_pkts: 1002
>>>> tx_q-1_pkts: 2679
>>>> tx_q-2_pkts: 1113
>>>> tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
>>>> rx_q-0_pkts: 1143
>>>> rx_q-1_pkts: 3172
>>>> rx_q-2_pkts: 1074
>>>>
>>>> After:
>>>>
>>>> ethtool -L eth1 tx 1 combined 3
>>>>
>>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
>>>>
>>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
>>>> /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
>>>> /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
>>>> /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
>>>> /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
>>>>
>>>> ethtool -S eth1 | grep -v ': 0'
>>>> NIC statistics:
>>>> tx_q-0_pkts: 118
>>>> tx_q-1_pkts: 134
>>>> tx_q-2_pkts: 228
>>>> tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
>>>> rx_q-0_pkts: 111
>>>> rx_q-1_pkts: 366
>>>> rx_q-2_pkts: 120
>>>
>>> Are there any ABI issues here?
>>
>> The patch doesn't change the format, it just fixes the numbering in
>> the name to make it consistent with other reporting tools. It
>> shouldn't break any library.
>
> But is the numbering part of the ABI?
>
> Making a comment about ABI in the commit message makes it clear it is
> something you have considered, and you have decided it is not an
> issue. If there is no such comment, reviewers probably should ask.
>
> Andrew
I don't see how an application can depend on the name if it can't
correlate it to anything meaningful. The change fixes the ID values used
so that they *do* correlate. If an application was previously assuming
it correlated to the queue ID, it would incorrect associate the IRQ with
the wrong queue.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 20:46 ` [Intel-wired-lan] " Jacob Keller
@ 2026-01-26 20:51 ` Eric Dumazet
2026-01-26 21:12 ` Andrew Lunn
0 siblings, 1 reply; 9+ messages in thread
From: Eric Dumazet @ 2026-01-26 20:51 UTC (permalink / raw)
To: Jacob Keller
Cc: Andrew Lunn, Brian Vazquez, Brian Vazquez, Tony Nguyen,
Przemek Kitszel, David S. Miller, Jakub Kicinski, Paolo Abeni,
intel-wired-lan, David Decotigny, Li Li, Anjali Singhai,
Sridhar Samudrala, linux-kernel, netdev, emil.s.tantilov,
Brett Creeley, Aleksandr Loktionov
On Mon, Jan 26, 2026 at 9:46 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>
>
>
> On 1/26/2026 9:53 AM, Andrew Lunn wrote:
> > On Mon, Jan 26, 2026 at 12:40:15PM -0500, Brian Vazquez wrote:
> >> On Mon, Jan 26, 2026 at 11:24 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >>>
> >>> On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
> >>>> The code uses the vidx for the IRQ name but that doesn't match ethtool
> >>>> reporting or netdev naming, this makes it hard to tune the device and
> >>>> associate queues with IRQs. Sequentially requesting irqs starting from
> >>>> '0' makes the output consistent.
> >>>>
> >>>> Before:
> >>>>
> >>>> ethtool -L eth1 tx 1 combined 3
> >>>>
> >>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> >>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> >>>> /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> >>>> /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> >>>> /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> >>>> /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
> >>>>
> >>>> ethtool -S eth1 | grep -v ': 0'
> >>>> NIC statistics:
> >>>> tx_q-0_pkts: 1002
> >>>> tx_q-1_pkts: 2679
> >>>> tx_q-2_pkts: 1113
> >>>> tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> >>>> rx_q-0_pkts: 1143
> >>>> rx_q-1_pkts: 3172
> >>>> rx_q-2_pkts: 1074
> >>>>
> >>>> After:
> >>>>
> >>>> ethtool -L eth1 tx 1 combined 3
> >>>>
> >>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> >>>>
> >>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> >>>> /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> >>>> /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> >>>> /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> >>>> /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
> >>>>
> >>>> ethtool -S eth1 | grep -v ': 0'
> >>>> NIC statistics:
> >>>> tx_q-0_pkts: 118
> >>>> tx_q-1_pkts: 134
> >>>> tx_q-2_pkts: 228
> >>>> tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> >>>> rx_q-0_pkts: 111
> >>>> rx_q-1_pkts: 366
> >>>> rx_q-2_pkts: 120
> >>>
> >>> Are there any ABI issues here?
> >>
> >> The patch doesn't change the format, it just fixes the numbering in
> >> the name to make it consistent with other reporting tools. It
> >> shouldn't break any library.
> >
> > But is the numbering part of the ABI?
> >
> > Making a comment about ABI in the commit message makes it clear it is
> > something you have considered, and you have decided it is not an
> > issue. If there is no such comment, reviewers probably should ask.
> >
> > Andrew
>
> I don't see how an application can depend on the name if it can't
> correlate it to anything meaningful. The change fixes the ID values used
> so that they *do* correlate. If an application was previously assuming
> it correlated to the queue ID, it would incorrect associate the IRQ with
> the wrong queue.
Agree, this mismatch caused me some surprises, we can not keep a broken
ABI (which has been broken by accident)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 20:51 ` Eric Dumazet
@ 2026-01-26 21:12 ` Andrew Lunn
2026-01-26 21:55 ` Brian Vazquez
0 siblings, 1 reply; 9+ messages in thread
From: Andrew Lunn @ 2026-01-26 21:12 UTC (permalink / raw)
To: Eric Dumazet
Cc: Jacob Keller, Brian Vazquez, Brian Vazquez, Tony Nguyen,
Przemek Kitszel, David S. Miller, Jakub Kicinski, Paolo Abeni,
intel-wired-lan, David Decotigny, Li Li, Anjali Singhai,
Sridhar Samudrala, linux-kernel, netdev, emil.s.tantilov,
Brett Creeley, Aleksandr Loktionov
On Mon, Jan 26, 2026 at 09:51:10PM +0100, Eric Dumazet wrote:
> On Mon, Jan 26, 2026 at 9:46 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
> >
> >
> >
> > On 1/26/2026 9:53 AM, Andrew Lunn wrote:
> > > On Mon, Jan 26, 2026 at 12:40:15PM -0500, Brian Vazquez wrote:
> > >> On Mon, Jan 26, 2026 at 11:24 AM Andrew Lunn <andrew@lunn.ch> wrote:
> > >>>
> > >>> On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
> > >>>> The code uses the vidx for the IRQ name but that doesn't match ethtool
> > >>>> reporting or netdev naming, this makes it hard to tune the device and
> > >>>> associate queues with IRQs. Sequentially requesting irqs starting from
> > >>>> '0' makes the output consistent.
> > >>>>
> > >>>> Before:
> > >>>>
> > >>>> ethtool -L eth1 tx 1 combined 3
> > >>>>
> > >>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > >>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > >>>> /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> > >>>> /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> > >>>> /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> > >>>> /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
> > >>>>
> > >>>> ethtool -S eth1 | grep -v ': 0'
> > >>>> NIC statistics:
> > >>>> tx_q-0_pkts: 1002
> > >>>> tx_q-1_pkts: 2679
> > >>>> tx_q-2_pkts: 1113
> > >>>> tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> > >>>> rx_q-0_pkts: 1143
> > >>>> rx_q-1_pkts: 3172
> > >>>> rx_q-2_pkts: 1074
> > >>>>
> > >>>> After:
> > >>>>
> > >>>> ethtool -L eth1 tx 1 combined 3
> > >>>>
> > >>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > >>>>
> > >>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > >>>> /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> > >>>> /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> > >>>> /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> > >>>> /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
> > >>>>
> > >>>> ethtool -S eth1 | grep -v ': 0'
> > >>>> NIC statistics:
> > >>>> tx_q-0_pkts: 118
> > >>>> tx_q-1_pkts: 134
> > >>>> tx_q-2_pkts: 228
> > >>>> tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> > >>>> rx_q-0_pkts: 111
> > >>>> rx_q-1_pkts: 366
> > >>>> rx_q-2_pkts: 120
> > >>>
> > >>> Are there any ABI issues here?
> > >>
> > >> The patch doesn't change the format, it just fixes the numbering in
> > >> the name to make it consistent with other reporting tools. It
> > >> shouldn't break any library.
> > >
> > > But is the numbering part of the ABI?
> > >
> > > Making a comment about ABI in the commit message makes it clear it is
> > > something you have considered, and you have decided it is not an
> > > issue. If there is no such comment, reviewers probably should ask.
> > >
> > > Andrew
> >
> > I don't see how an application can depend on the name if it can't
> > correlate it to anything meaningful. The change fixes the ID values used
> > so that they *do* correlate. If an application was previously assuming
> > it correlated to the queue ID, it would incorrect associate the IRQ with
> > the wrong queue.
>
> Agree, this mismatch caused me some surprises, we can not keep a broken
> ABI (which has been broken by accident)
So everybody is agreed, great. I just think it would of been good to
mention ABI in the commit message, to show due diligence has been
done.
Andrew
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering
2026-01-26 21:12 ` Andrew Lunn
@ 2026-01-26 21:55 ` Brian Vazquez
0 siblings, 0 replies; 9+ messages in thread
From: Brian Vazquez @ 2026-01-26 21:55 UTC (permalink / raw)
To: Andrew Lunn
Cc: Eric Dumazet, Jacob Keller, Brian Vazquez, Tony Nguyen,
Przemek Kitszel, David S. Miller, Jakub Kicinski, Paolo Abeni,
intel-wired-lan, David Decotigny, Li Li, Anjali Singhai,
Sridhar Samudrala, linux-kernel, netdev, emil.s.tantilov,
Brett Creeley, Aleksandr Loktionov
Sure, sending v3 to add more details about the ABI.
On Mon, Jan 26, 2026 at 4:12 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Jan 26, 2026 at 09:51:10PM +0100, Eric Dumazet wrote:
> > On Mon, Jan 26, 2026 at 9:46 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
> > >
> > >
> > >
> > > On 1/26/2026 9:53 AM, Andrew Lunn wrote:
> > > > On Mon, Jan 26, 2026 at 12:40:15PM -0500, Brian Vazquez wrote:
> > > >> On Mon, Jan 26, 2026 at 11:24 AM Andrew Lunn <andrew@lunn.ch> wrote:
> > > >>>
> > > >>> On Mon, Jan 26, 2026 at 02:46:24PM +0000, Brian Vazquez wrote:
> > > >>>> The code uses the vidx for the IRQ name but that doesn't match ethtool
> > > >>>> reporting or netdev naming, this makes it hard to tune the device and
> > > >>>> associate queues with IRQs. Sequentially requesting irqs starting from
> > > >>>> '0' makes the output consistent.
> > > >>>>
> > > >>>> Before:
> > > >>>>
> > > >>>> ethtool -L eth1 tx 1 combined 3
> > > >>>>
> > > >>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > > >>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > > >>>> /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0
> > > >>>> /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1
> > > >>>> /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2
> > > >>>> /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3
> > > >>>>
> > > >>>> ethtool -S eth1 | grep -v ': 0'
> > > >>>> NIC statistics:
> > > >>>> tx_q-0_pkts: 1002
> > > >>>> tx_q-1_pkts: 2679
> > > >>>> tx_q-2_pkts: 1113
> > > >>>> tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5
> > > >>>> rx_q-0_pkts: 1143
> > > >>>> rx_q-1_pkts: 3172
> > > >>>> rx_q-2_pkts: 1074
> > > >>>>
> > > >>>> After:
> > > >>>>
> > > >>>> ethtool -L eth1 tx 1 combined 3
> > > >>>>
> > > >>>> grep . /proc/irq/*/*idpf*/../smp_affinity_list
> > > >>>>
> > > >>>> /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167
> > > >>>> /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0
> > > >>>> /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1
> > > >>>> /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2
> > > >>>> /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3
> > > >>>>
> > > >>>> ethtool -S eth1 | grep -v ': 0'
> > > >>>> NIC statistics:
> > > >>>> tx_q-0_pkts: 118
> > > >>>> tx_q-1_pkts: 134
> > > >>>> tx_q-2_pkts: 228
> > > >>>> tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3
> > > >>>> rx_q-0_pkts: 111
> > > >>>> rx_q-1_pkts: 366
> > > >>>> rx_q-2_pkts: 120
> > > >>>
> > > >>> Are there any ABI issues here?
> > > >>
> > > >> The patch doesn't change the format, it just fixes the numbering in
> > > >> the name to make it consistent with other reporting tools. It
> > > >> shouldn't break any library.
> > > >
> > > > But is the numbering part of the ABI?
> > > >
> > > > Making a comment about ABI in the commit message makes it clear it is
> > > > something you have considered, and you have decided it is not an
> > > > issue. If there is no such comment, reviewers probably should ask.
> > > >
> > > > Andrew
> > >
> > > I don't see how an application can depend on the name if it can't
> > > correlate it to anything meaningful. The change fixes the ID values used
> > > so that they *do* correlate. If an application was previously assuming
> > > it correlated to the queue ID, it would incorrect associate the IRQ with
> > > the wrong queue.
> >
> > Agree, this mismatch caused me some surprises, we can not keep a broken
> > ABI (which has been broken by accident)
>
> So everybody is agreed, great. I just think it would of been good to
> mention ABI in the commit message, to show due diligence has been
> done.
>
> Andrew
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-01-26 21:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 14:46 [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering Brian Vazquez
2026-01-26 16:24 ` Andrew Lunn
2026-01-26 17:40 ` Brian Vazquez
2026-01-26 17:53 ` Andrew Lunn
2026-01-26 20:46 ` [Intel-wired-lan] " Jacob Keller
2026-01-26 20:51 ` Eric Dumazet
2026-01-26 21:12 ` Andrew Lunn
2026-01-26 21:55 ` Brian Vazquez
2026-01-26 17:28 ` Paul Menzel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox