From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E38E78F3E; Tue, 27 Jan 2026 00:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769473033; cv=none; b=KXtMo4+hgDNXJInV1MQNVrbFD12rf4vUsRcguPtj4vMHnL0G2LinqcxlroxR09A7mY0XgIRXU33tro1HFDarhMU4/GUNLax75FVx6ox/extAfwY77zttbxOanuJR3z71lJ++alnerzE+XD55ryBy6Z0U6LOiDbr8yJwZgutEQu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769473033; c=relaxed/simple; bh=KkOYQevkpGOrnDIoJPRQGxUkPN409sQyfY4sFH+8OzY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H47fylQOiUJRn1oTZIK6yaK6ArTnXyuMdAx2RQhsUq4gcfR0RV9ESZEkaQ54YhzPZKgH7ma5WjERu8OrJYeJEyKOeUmxdO9ygNruNeQIwNoic7D3dHYSRTD9SdVIsXpsOw0SbqpAlih0hCr+xhSzMmA9UMbiLTZo2zlzATuP94s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mt+E/Psq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mt+E/Psq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83B83C116C6; Tue, 27 Jan 2026 00:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769473033; bh=KkOYQevkpGOrnDIoJPRQGxUkPN409sQyfY4sFH+8OzY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mt+E/PsqP0byrVFgyagQnoUX1xKvoR618QUcQ9TXglRCWaMri7VLyQVNwFPZCEboz I6jZSPuZKykSZYDXibh/f9dpz+fN6bayGcTqkdjQDJy/n52LormX9deMT44XWtAq+E R2XAenRVgsdA7JWrsZYnE/o66SlLfvTLeLQFjpzn8k/JfcKXN4QOblLlm0DF6BvPm4 zY514/2/v1oud4d45dejbl700KofsgzFRgaHcLQPMIJ7xj35q1F9WNjlls/n9/NopU 0C1yr09TVCdkol7D2HyyWWk1st51X1uN8hy0ZtZmkMDbDZsUCXEar+hQyxRMlA/dWQ 3CxQdYtyhaDOQ== Date: Mon, 26 Jan 2026 16:17:11 -0800 From: Jakub Kicinski To: Wei Fang Cc: "john.fastabend@gmail.com" , "linux-kernel@vger.kernel.org" , Shenwei Wang , "daniel@iogearbox.net" , Frank Li , "netdev@vger.kernel.org" , Clark Wang , "ast@kernel.org" , "sdf@fomichev.me" , "imx@lists.linux.dev" , "davem@davemloft.net" , "edumazet@google.com" , "hawk@kernel.org" , "bpf@vger.kernel.org" , "pabeni@redhat.com" , "andrew+netdev@lunn.ch" Subject: Re: [v4,net-next,06/15] net: fec: add fec_enet_rx_queue_xdp() for XDP path Message-ID: <20260126161711.2ee02510@kernel.org> In-Reply-To: References: <20260123022143.4121797-7-wei.fang@nxp.com> <20260125214446.3383999-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 26 Jan 2026 02:09:13 +0000 Wei Fang wrote: > Therefore, xdp program will not be installed for those platforms which > need swap_buffer(). Because the XDP path and the traditional protocol > stack path were previously mixed in fec_enet_rx_queue(), the logic was > confused, which led to the AI =E2=80=8B=E2=80=8Bmaking a misjudgment. Understood, could you add a note to this effect in the commit message to try to steer the AI away?