* [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const
@ 2026-01-27 16:16 Simon Horman
2026-01-27 16:21 ` [Intel-wired-lan] " Paul Menzel
2026-01-28 6:33 ` Loktionov, Aleksandr
0 siblings, 2 replies; 3+ messages in thread
From: Simon Horman @ 2026-01-27 16:16 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Tony Nguyen, Przemek Kitszel, Richard Cochran, netdev
The name member of struct ice_cgu_pin_desc never modified.
Make it const.
Found by inspection.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
index 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc00e06f26cab5c 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
+++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins {
};
struct ice_cgu_pin_desc {
- char *name;
+ const char *name;
u8 index;
enum dpll_pin_type type;
u32 freq_supp_num;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const
2026-01-27 16:16 [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const Simon Horman
@ 2026-01-27 16:21 ` Paul Menzel
2026-01-28 6:33 ` Loktionov, Aleksandr
1 sibling, 0 replies; 3+ messages in thread
From: Paul Menzel @ 2026-01-27 16:21 UTC (permalink / raw)
To: Simon Horman
Cc: intel-wired-lan, Tony Nguyen, Przemek Kitszel, Richard Cochran,
netdev
Dear Simon,
Thank you for your patch.
Am 27.01.26 um 17:16 schrieb Simon Horman:
> The name member of struct ice_cgu_pin_desc never modified.
> Make it const.
>
> Found by inspection.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> index 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc00e06f26cab5c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> @@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins {
> };
>
> struct ice_cgu_pin_desc {
> - char *name;
> + const char *name;
> u8 index;
> enum dpll_pin_type type;
> u32 freq_supp_num;
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul Menzel
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const
2026-01-27 16:16 [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const Simon Horman
2026-01-27 16:21 ` [Intel-wired-lan] " Paul Menzel
@ 2026-01-28 6:33 ` Loktionov, Aleksandr
1 sibling, 0 replies; 3+ messages in thread
From: Loktionov, Aleksandr @ 2026-01-28 6:33 UTC (permalink / raw)
To: Simon Horman, intel-wired-lan@lists.osuosl.org
Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, Richard Cochran,
netdev@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Simon Horman
> Sent: Tuesday, January 27, 2026 5:17 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; Richard Cochran
> <richardcochran@gmail.com>; netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of
> struct ice_cgu_pin_desc const
>
> The name member of struct ice_cgu_pin_desc never modified.
> Make it const.
>
> Found by inspection.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> index
> 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc0
> 0e06f26cab5c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> @@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins { };
>
> struct ice_cgu_pin_desc {
> - char *name;
> + const char *name;
> u8 index;
> enum dpll_pin_type type;
> u32 freq_supp_num;
>
>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-28 6:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-27 16:16 [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const Simon Horman
2026-01-27 16:21 ` [Intel-wired-lan] " Paul Menzel
2026-01-28 6:33 ` Loktionov, Aleksandr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox