From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E830C1DF72C for ; Tue, 27 Jan 2026 00:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769474465; cv=none; b=tsdEI+D5tUlEbRiYziKbrMuQuKuXslqnKj7rVbda9NCYQGIH7cDeVLaWG92iWW7lCgspiQk9ue54hKXsAJk6gdKttuvMNxHnjQjkELrlEHIOuV2sndO+HoaP/cfromjFc8/l8fFEwD9rFpq1dNKJF6dVzAOmQoxotxYjrWglr6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769474465; c=relaxed/simple; bh=nB6yjbNXx42GKTBaXT02ZrBwPDOQ+Wsz8KL8vGzVQaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zz8InAcrDvcqNhg+6m9H2gfAVI4env3i/zGLdFSQIFELpPJK8lVYdaaHRDNWOLVA+2AVVnaYarbG8FBQF17GYgUVFNcvllAmtwRZzeGwuYPJ10VQNFnbw1KQvYlPweoXuI8dmKr1cWeW7c6h3UYgdKRgN02mBb03tVYiRk8kBDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nCLiRYhX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nCLiRYhX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AEAAC116C6; Tue, 27 Jan 2026 00:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769474464; bh=nB6yjbNXx42GKTBaXT02ZrBwPDOQ+Wsz8KL8vGzVQaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nCLiRYhXSjC0cyWgFzfpBfJz3GNGLNuwr8vZmbLNiPP0025V4EsEpQZ2mNpPf5yLV S+N/f4ZgDlNfz6MiEJahyApVGOTfnTp3e/Dhyj39TDiQfKpKYyw6UsxbPCG4wiwQog PDXoIrevY3UX/IqyOqJQpVLeSRwWcON7gX1EthcZZV9NqkeUMMpfICM7AnomZSpJKA IS8yLo13jC5CYTQk39EdkZpsbmvdOyUgwkppwIHx3E/0anYLWw2rOIXPsJIobLh213 5CqFqOGb5/euCk663qw+qv+iYaPHWqs+DIEFRzsbCVhxJFHwSFBJnzsU8q+5kvtUxF ArgQDm22sXoKQ== From: Jakub Kicinski To: rmk+kernel@armlinux.org.uk Cc: Jakub Kicinski , linux-stm32@st-md-mailman.stormreply.com, andrew+netdev@lunn.ch, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, pabeni@redhat.com, linux-rockchip@lists.infradead.org, heiko@sntech.de, alexandre.torgue@foss.st.com, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com Subject: Re: [net-next,v2,22/22] net: stmmac: rk: rk3506, rk3528 and kk3588 have rmii_mode in clock register Date: Mon, 26 Jan 2026 16:41:03 -0800 Message-ID: <20260127004103.3785897-1-kuba@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net: stmmac: rk: rk3506, rk3528 and kk3588 have rmii_mode in clock register This patch moves the rmii_mode bit configuration for rk3506, rk3528 and rk3588 from the SoC-specific set_to_rmii() functions to the common rk_gmac_powerup() path, using the new rmii_mode_mask field in the clock register configuration. > net: stmmac: rk: rk3506, rk3528 and kk3588 have rmii_mode in clock register ^^^^^^ This isn't a bug, but the subject line has a typo: "kk3588" should be "rk3588". The commit body correctly refers to "rk3588" and the code changes reference rk3588_ops, rk3588_init, and RK3588_* macros.