From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] declance: Remove IRQF_ONESHOT
Date: Tue, 27 Jan 2026 09:49:53 +0100 [thread overview]
Message-ID: <20260127084953.knXW3cK4@linutronix.de> (raw)
In-Reply-To: <20260126194054.79e6f56d@kernel.org>
On 2026-01-26 19:40:54 [-0800], Jakub Kicinski wrote:
> > lance_dma_merr_int() does nothing but a printk() which means if it is a
> > level interrupt then once it fires it remains asserted and that printk()
> > takes over the machine.
> > I guess it never fires and is just left over debug.
>
> have you seen 0fabe1021f8bc9cffdede4ddad0dd04d43c5166c ?
no, I did now.
> Sounds like it may have been a hack local to MIPS.
> On a quick read indeed your changes seems fine but it would give us
> certain warm and fuzzies to have the commit message refer to and
> reason about the patch that introduced the flag..
Will do so.
Sebastian
prev parent reply other threads:[~2026-01-27 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 11:06 [PATCH net-next] declance: Remove IRQF_ONESHOT Sebastian Andrzej Siewior
2026-01-27 3:40 ` Jakub Kicinski
2026-01-27 8:49 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127084953.knXW3cK4@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox