From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com [52.42.203.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846543161AD for ; Tue, 27 Jan 2026 08:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.42.203.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769504068; cv=none; b=opHJZK6ss5zIbwyMkBHUOCmfQ3OSanotcdN0W+vYPO+ihoPRYv7uSotxir6USITc8CyG8WRbBvZ0J/hbAMNJ9TntGI4E9LAqgNGkhD4SgL1+INBb4WPAme6tNLKL2x7rEowouz98pZeWYLhwiKbvR/PyeMl2GRQIbEBENMesyK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769504068; c=relaxed/simple; bh=/3KaE3293Z9MOo7jgtqOjW6PaGhQDqJFLr5TO0PBdq8=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=OFGhhv1W3yWVH1kKCAm5IWltAdJOr8BJLoQT7tP/yCKNZHlI6bTuhy3VzeKX6uQFScDN74ZFAeOysx5vBdeonzsUZ4ukxFMwWDy4eJaNgnU4c2EogWCrGGuW4g5O9bqPs3TZ6HanGQZCi7DpOcP74n1Yhbg2g5tw37CnniibSIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=jM7q9RF0; arc=none smtp.client-ip=52.42.203.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="jM7q9RF0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1769504067; x=1801040067; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5Vu2GOUUTUkzQBR4MGj91wDX9S48NAbJAlRo+YnFDDU=; b=jM7q9RF0mrVkK62UzTfcGjjQ6VTJrSdxDYp4Sm6h/H6zwe+WvNPCQSlS XHKev6fi3hIigPz4pf0oFJI+8urBZc6k/6xFZ+N4XOPTsS+YWsY9AYe7O 8GFachHL7xtExBVlY/jHNo8Lnp5pa1QXxSQJPgaGwU73kDsWTYiLWn55L 4De6bTk/JQUwosDtJQ8wrR0w5yDcKJNbAomj9dC4wihdfyv6R/CZEuaQx uJqkHp83YL1KNacQM7iHNaTaPEFZVa+ivy9nDkdUaTVYX1vN5t92DA9YM bfD5U5BkBqVSmQmGT99Awdz3VXXLLSRmsHBc/FdSLNnlzC/4n0CeJ1gmE A==; X-CSE-ConnectionGUID: PKJUmrdeS6mevJl3rA2FPA== X-CSE-MsgGUID: TajFWLVmQOCONlZAeeyy8A== X-IronPort-AV: E=Sophos;i="6.21,256,1763424000"; d="scan'208";a="11660345" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 08:54:24 +0000 Received: from EX19MTAUWC002.ant.amazon.com [205.251.233.51:26705] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.19.122:2525] with esmtp (Farcaster) id 8abc2707-6992-48fe-a36f-6b2eefa5c4a0; Tue, 27 Jan 2026 08:54:24 +0000 (UTC) X-Farcaster-Flow-ID: 8abc2707-6992-48fe-a36f-6b2eefa5c4a0 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Tue, 27 Jan 2026 08:54:23 +0000 Received: from 603e5f7bc1fe.amazon.com (10.37.245.7) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Tue, 27 Jan 2026 08:54:21 +0000 From: Takashi Kozu To: CC: , , , , , , , , , , , , Takashi Kozu Subject: [PATCH iwl-next v5 0/3] igb: add RSS key get/set support Date: Tue, 27 Jan 2026 17:54:07 +0900 Message-ID: <20260127085410.79645-5-takkozu@amazon.com> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EX19D037UWC004.ant.amazon.com (10.13.139.254) To EX19D001UWA001.ant.amazon.com (10.13.138.214) This series adds ethtool get/set support for the RSS hash key in the igb driver. - `ethtool -x ` to display the RSS key - `ethtool -X hkey ` to configure the RSS key Without patch: # ethtool -x $DEV | grep key -A1 RSS hash key: Operation not supported # ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:00:00:00:000 Cannot set RX flow hash configuration: Hash key setting not supported With patch: # ethtool -x $DEV | grep key -A1 RSS hash key: 86:5d:11:56:bd:6f:20:38:3b:f8:bb:df:00:3a:b0:24:95:9f:f9:f4:25:a3:01:3e:4a:15:d6:7c:4d:af:39:7e:4a:95:f2:fd:f6:b6:26:f7 # ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00 # ethtool -x $DEV | grep key -A1 RSS hash key: 00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00 v5: - delete 'has_user_rss_key' flag because it's unnecessary. v4: - modify the position of the declaration in the igb_write_rss_key() so that it is at the start of the block. v3: - add ASSERT_RTNL() to explicitly show that an rtnl lock is being used - Move netdev_rss_key_fill() function from igb_setup_mrqc() to igb_sw_init() - Add kernel-doc header to igb_write_rss_key() - tools/testing/selftests/drivers/net/hw/rss_api.py is successful Run the following command # NETIF=enp0s3 python tools/testing/selftests/drivers/net/hw/rss_api.py | grep -v "# Exception" Then, I checked the diffs before and after applying the patch $ diff beforePatch.txt afterPatch.txt 9c9 < not ok 6 rss_api.test_rxfh_nl_set_key --- > ok 6 rss_api.test_rxfh_nl_set_key 16c16 < # Totals: pass:4 fail:8 xfail:0 xpass:0 skip:0 error:0 --- > # Totals: pass:5 fail:7 xfail:0 xpass:0 skip:0 error:0 The failing tests originally fails due to hardware. - tools/testing/selftests/drivers/net/hw/toeplitz.py is untested since there is no actual hardware, but since the logic around wr32() is preserved as it is, key writing to the device remain the same. v2: Fix typos (igc_* → igb_*) https://lore.kernel.org/intel-wired-lan/20260108052020.84218-5-takkozu@amazon.com/T/ v1: https://lore.kernel.org/all/20251205082106.4028-5-takkozu@amazon.com/ Takashi Kozu (3): igb: prepare for RSS key get/set support igb: expose RSS key via ethtool get_rxfh igb: allow configuring RSS key via ethtool set_rxfh drivers/net/ethernet/intel/igb/igb.h | 3 + drivers/net/ethernet/intel/igb/igb_ethtool.c | 85 ++++++++++++++------ drivers/net/ethernet/intel/igb/igb_main.c | 8 +- 3 files changed, 66 insertions(+), 30 deletions(-) -- 2.52.0