From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE4001AC44D for ; Tue, 27 Jan 2026 17:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769534157; cv=none; b=gdk5XaONlJaEqPLA2NMcZOqiMnKoEMuvyDmfHkr4eGWQRjI7Mgpwp8WtXUrN09ZbSGJ8A87MCIjiUeOc41pr2YHOZKDPZw39Yq99P8KOzrPH9Hh/k0mv/FycwfWhhDFqjLfkw4GqUnj37irSMwe/fKrshN6kjJ49j/2rWoY4xEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769534157; c=relaxed/simple; bh=XrARRcInRBz966ra6bqqa7zNSjmFxAULR2fkEa7Q5GE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s3wtTIFkh3tpOYVGoB2y7AEDgCkODrVAZ04wYalGjK6Z/70wb43n9364yT7H1W7fNB32g9McByivsJgxJCxSJTB9g1S+Gfj4fRXbuV9pVfHQ6ui/otQKoty0Klko6ics3e5g6tHqYb8WyMTfHkTP74uF0gU8LKhCblsAkBM1Cko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lQw1gluR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lQw1gluR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FA00C116C6; Tue, 27 Jan 2026 17:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769534157; bh=XrARRcInRBz966ra6bqqa7zNSjmFxAULR2fkEa7Q5GE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lQw1gluRZqMBUQeFXCKweHeZ6SvfkPPR8bHFwpInpvIcFnmsTOxebebGsLgkwhegm 0MB8yGEpHaSmZRkbyz9SZiceSWmj8aWAhrtW+rPdJ9Ysq6KrT/7Ot/eE+y8y0teymJ 6jTusJf3ofSjh05qD+URhjVEbpLxsl62YQVBkUqVkVh78l5I0Xdgg5DzsgugvHaU6h KyEp2doIWxQzB+x/wDh/UDsm4QfJt9bL4vQLwkTxGgNSzisbHYzAB+Og8AObvBj5il n0bsoYPow41ow4jKgpw/5gWUWoRdqKsKHVaUGmT0l85euVST0uEfm4yvggVEnFbqd/ 31lUALfvSyAcA== Date: Tue, 27 Jan 2026 09:15:56 -0800 From: Jakub Kicinski To: Jamal Hadi Salim , Cong Wang Cc: netdev@vger.kernel.org Subject: Re: [Patch net v8 0/9] netem: Fix skb duplication logic and prevent infinite loops Message-ID: <20260127091556.052604cd@kernel.org> In-Reply-To: References: <20260118061515.930322-1-xiyou.wangcong@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 18 Jan 2026 10:07:37 -0500 Jamal Hadi Salim wrote: > On Sun, Jan 18, 2026 at 1:16=E2=80=AFAM Cong Wang wrote: > > This patchset fixes the infinite loops due to duplication in netem, the > > real root cause of this problem is enqueuing to the root qdisc, which is > > now changed to enqueuing to the same qdisc. This is more reasonable, > > more intuitive from users' perspective, less error-prone and more elega= nt > > from kernel developers' perspective. > > > > Please see more details in patch 4/9 which contains two pages of detail= ed > > explanation including why it is safe and better. > > > > This reverts the offending commits from William which clearly broke > > mq+netem use cases, as reported by two users. > > > > All the TC test cases pass with this patchset. > > =20 >=20 > These patches should not be considered for any review because they are > not following the rules that are set for the community. The rules, > which are well documented, state that you must cc all stakeholders. > When someone does this _on purpose_ such as Cong, some accountability > needs to be imposed. I would say totally ignoring these patches is one > option. Otherwise anyone can just throw a tantrum and decide those > rules dont apply to them. Either that or we modify the rules to state > it is ok to do this.. We (the netdev maintainers) had a chat off list and concluded that it'd be great if we (the two of you and one maintainer) met over VC. Either technical solution is fine, but we want to make sure there's no ongoing animosity. No agenda for the meeting, just want to make sure you can have a friendly chat. We can talk about the weather, AI code reviews or everyone's favorite animals. At the end of the meeting we can either decide or flip a coin.