public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Ratheesh Kannoth <rkannoth@marvell.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Saeed Mahameed <saeedm@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Chuck Lever <chuck.lever@oracle.com>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Carolina Jubran <cjubran@nvidia.com>
Subject: Re: [PATCH net-next v2] devlink: Implement devlink param multi attribute nested data values
Date: Tue, 27 Jan 2026 10:04:29 -0800	[thread overview]
Message-ID: <20260127100429.26dc5258@kernel.org> (raw)
In-Reply-To: <rsngz5ql5s54luv4mnjs733uogjjdxiylbbm4w4pcaefow45rm@memr4a27ycc2>

On Tue, 27 Jan 2026 10:51:10 +0100 Jiri Pirko wrote:
> Tue, Jan 27, 2026 at 02:18:59AM +0100, kuba@kernel.org wrote:
> >On Mon, 26 Jan 2026 08:09:44 +0530 Ratheesh Kannoth wrote:  
> >> Devlink param value attribute is not defined since devlink is handling
> >> the value validating and parsing internally, this allows us to implement
> >> multi attribute values without breaking any policies.
> >> 
> >> Devlink param multi-attribute values are considered to be dynamically
> >> sized arrays of u32 values, by introducing a new devlink param type
> >> DEVLINK_PARAM_TYPE_U32_ARRAY, driver and user space can set a variable
> >> count of u32 values into the DEVLINK_ATTR_PARAM_VALUE_DATA attribute.
> >> 
> >> Implement get/set parsing and add to the internal value structure passed
> >> to drivers.
> >> 
> >> This is useful for devices that need to configure a list of values for
> >> a specific configuration.  
> >
> >Could you respin this as a series with the first driver implementing
> >a param of this type?  We can't merge an API without a user.  
> 
> I may be missed it, are you okay with cleanup helpers now (__free(kfree)
> used here), or not yet? :)

Of course not, I haven't looked at the patch at all.

  reply	other threads:[~2026-01-27 18:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26  2:39 [PATCH net-next v2] devlink: Implement devlink param multi attribute nested data values Ratheesh Kannoth
2026-01-27  1:18 ` Jakub Kicinski
2026-01-27  4:10   ` Ratheesh Kannoth
2026-01-27  9:51   ` Jiri Pirko
2026-01-27 18:04     ` Jakub Kicinski [this message]
2026-01-28  3:38       ` Ratheesh Kannoth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127100429.26dc5258@kernel.org \
    --to=kuba@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=cjubran@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rkannoth@marvell.com \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox