From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f201.google.com (mail-qk1-f201.google.com [209.85.222.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62400355026 for ; Tue, 27 Jan 2026 12:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769517516; cv=none; b=kiSsZvBBZEYkGklEwbc7I6t6ps4xMriWlHk2cyPb2DAHB53szNBAg+Of1UKKwR+AwRU08hrfBQAwQIWju5oKqhzX97/+kgJ/fNBS+dOlhKUci4g7tmmGa1vOAn03w23D72djIb2IM7YprVT6TAGO618XqwMjr+/VU6mmaptW4BI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769517516; c=relaxed/simple; bh=UwQfXjVA6/aNekkAEMxH3Vphc7MEP1+13GONKU5WWQ4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Hl2NgkM6q+8jDsYUq+UO6JSo2HQ4ICkG7IKG5cQWS7WmvpHeFDcAs8PqUWSYsYkOZFEdUqCtEniAQmBborb6PejJlI2S7YXCJ/zB6g7CCzFU30gZajZCiiwVs5WYrzRq2kkeyRPITU6+XffxqkZhYs6dtGaJ72spk2zhcEXzWxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2765yq8D; arc=none smtp.client-ip=209.85.222.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2765yq8D" Received: by mail-qk1-f201.google.com with SMTP id af79cd13be357-8c6b4058909so1309054585a.3 for ; Tue, 27 Jan 2026 04:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769517514; x=1770122314; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=CBZ5tJuuo1kDhPksgjemdrHPtXRVqLMT/4EEaJ3bmrw=; b=2765yq8DFloJia4SO+qEUux5h0dxKjDcT2KW7vqu778N0ugRkxNmPow4B2oo5WI5As WUOdkBLRY28y+Cs9B1Mvbn4wtvhNdcTMZk0DBaN45ObOEFLjBvCGhlGH4z/NtAytXAo+ IaIJclX4yzNvgeI+wTLDHFB5Kx+CjFlrgmJg9RpUbo4b+LvATEpiebsvyhKH7FqghABo sQwNokxr1+4lmLJMIqMpBIW/ayCx2rskNkHhhhTx8/lueoZQrfySji0TX6IfwuNizy6J T4QJF3w0u/c/s5zNn9LTb6st/bJKqZ34Ma7xNasC19KeM1N5kcJ5t9YF0PsjRgXJhOt7 ymSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769517514; x=1770122314; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CBZ5tJuuo1kDhPksgjemdrHPtXRVqLMT/4EEaJ3bmrw=; b=J1EtmA6mKrTv8zLmZIEdo8Hq7qnnX0P4JFf/bXtcTzlbpfmd0zVNUgBEsCGe+bqp20 RaWAJgjvthMLtCNduidN36oeX0Jpwcs7jJ3KHbSVowDyulgmJmACocK4ghc/kmZ2S8s/ QxuQd9cVLaVZyg6TAv0kkibSsLhDv2NftRBlfV0tlo9jSpa/t9OwH2ynZg0OxdqjQJMp jfnW5iRGuc238Ksm36IRp3m+ZTH0fzlJgrGWJdi5WVePdDKWStGb9VHzFEjMGK59Cail T7QU8f5QIRzhDqwxgA4/DOAnzYMT1ClyJJ8UxEl/6jxEk/OUWUbalhndz5vH6azfpijq 5TYw== X-Forwarded-Encrypted: i=1; AJvYcCXrYEp/vQhG3O4ge7H2XakThOsXBfN7bV0BrJIUiAnzX+oH0+yfXtuuF2VqyQFzD3fBmXz0IpE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx/8Dzw9/VOES2yga6CDb8ATh9vQGVdf0EchtvyE36Kcib5Fsj ox09l7Yn2ShbbXFgZxKzkT6L1uRLeAeBN7aOsBWV+sZsXyjpX4mb0zPdjS2+X4KvpkOdo0Gi/vR 2g9mXEv8fXjFfqg== X-Received: from qkvv16.prod.google.com ([2002:a05:620a:910:b0:8c7:f48:b8f1]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:620a:4891:b0:8bb:a346:8c84 with SMTP id af79cd13be357-8c70b86ee1emr157304985a.30.1769517514371; Tue, 27 Jan 2026 04:38:34 -0800 (PST) Date: Tue, 27 Jan 2026 12:38:28 +0000 In-Reply-To: <20260127123828.4098577-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260127123828.4098577-1-edumazet@google.com> X-Mailer: git-send-email 2.53.0.rc1.217.geba53bf80e-goog Message-ID: <20260127123828.4098577-3-edumazet@google.com> Subject: [PATCH net-next 2/2] selftest: packetdrill: add tcp_timestamping_tcp_tx_timestamp_bug.pkt From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Neal Cardwell , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" Test tcp_tx_timestamp() behavior after ("tcp: tcp_tx_timestamp() must look at the rtx queue"). Without the fix, this new test fails like this: tcp_timestamping_tcp_tx_timestamp_bug.pkt:55: runtime error in recvmsg call: Expected result 0 but got -1 with errno 11 (Resource temporarily unavailable) Signed-off-by: Eric Dumazet --- .../tcp_timestamping_tcp_tx_timestamp_bug.pkt | 70 +++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 tools/testing/selftests/net/packetdrill/tcp_timestamping_tcp_tx_timestamp_bug.pkt diff --git a/tools/testing/selftests/net/packetdrill/tcp_timestamping_tcp_tx_timestamp_bug.pkt b/tools/testing/selftests/net/packetdrill/tcp_timestamping_tcp_tx_timestamp_bug.pkt new file mode 100644 index 0000000000000000000000000000000000000000..95a1957a2cf9c8d52946174c01241b1a911e4e02 --- /dev/null +++ b/tools/testing/selftests/net/packetdrill/tcp_timestamping_tcp_tx_timestamp_bug.pkt @@ -0,0 +1,70 @@ +// SPDX-License-Identifier: GPL-2.0 +// Test after "tcp: tcp_tx_timestamp() must look at the rtx queue" + +// This test is about receiving the SCM_TSTAMP_ACK, +// we do not care about its SCM_TIMESTAMPING precision. +--tolerance_usecs=1000000 + +`./defaults.sh +sysctl -q net.ipv4.tcp_min_tso_segs=70 +` + +// Create a socket and set it to non-blocking. + 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 + +0 fcntl(3, F_GETFL) = 0x2 (flags O_RDWR) + +0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0 + +// Establish connection and verify that there was no error. + +0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress) + +0 > S 0:0(0) ++.010 < S. 0:0(0) ack 1 win 65535 + +0 > . 1:1(0) ack 1 + +0 getsockopt(3, SOL_SOCKET, SO_ERROR, [0], [4]) = 0 + +0 setsockopt(3, SOL_SOCKET, SO_SNDBUF, [30000], 4) = 0 + + +0 write(3, ..., 9880) = 9880 + +0 > P. 1:9881(9880) ack 1 ++.010 < . 1:1(0) ack 9881 win 10000 + + +0 write(3, ..., 19760) = 19760 + +0 > P. 9881:29641(19760) ack 1 ++.010 < . 1:1(0) ack 29641 win 10000 + + +0 write(3, ..., 39520) = 39520 + +0 > P. 29641:69161(39520) ack 1 ++.010 < . 1:1(0) ack 69161 win 10000 + +// One more write to increase cwnd + +0 write(3, ..., 79040) = 79040 + +0 > P. 69161:108681(39520) ack 1 + +0 > P. 108681:148201(39520) ack 1 ++.010 < . 1:1(0) ack 148201 win 1000 + + +0 setsockopt(3, SOL_SOCKET, SO_TIMESTAMPING, + [SOF_TIMESTAMPING_TX_ACK | SOF_TIMESTAMPING_SOFTWARE | + SOF_TIMESTAMPING_OPT_ID], 4) = 0 + +// We have one write filling one skb +// last byte can not be stored because of our small SO_SNDBUF + +0 write(3, ..., 65209) = 65208 + +0 > P. 148201:213409(65208) ack 1 ++.010 < . 1:1(0) ack 213409 win 1000 + +// SCM_TSTAMP_ACK should be received after the last ack at +// t=60ms. + +0 recvmsg(3, {msg_name(...)=..., + msg_iov(1)=[{...,0}], + msg_flags=MSG_ERRQUEUE|MSG_TRUNC, + msg_control=[ + {cmsg_level=SOL_SOCKET, + cmsg_type=SCM_TIMESTAMPING, + cmsg_data={scm_sec=0,scm_nsec=60000000}}, + {cmsg_level=CMSG_LEVEL_IP, + cmsg_type=CMSG_TYPE_RECVERR, + cmsg_data={ee_errno=ENOMSG, + ee_origin=SO_EE_ORIGIN_TIMESTAMPING, + ee_type=0, + ee_code=0, + ee_info=SCM_TSTAMP_ACK, + ee_data=65207}} + ]}, MSG_ERRQUEUE) = 0 -- 2.53.0.rc1.217.geba53bf80e-goog