Re: [net-next,V6,01/14] documentation: networking: add shared devlink documentation

[Simon Horman <horms@kernel.org>]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html

---
    documentation: networking: add shared devlink documentation

This commit adds RST documentation for the shared devlink instance
feature, which allows multiple PFs on the same chip to share a devlink
instance for chip-wide operations.

> diff --git a/Documentation/networking/devlink/devlink-shared.rst b/Documentation/networking/devlink/devlink-shared.rst
> new file mode 100644
> index 000000000000..a455e70b1b6e
> --- /dev/null
> +++ b/Documentation/networking/devlink/devlink-shared.rst

[ ... ]

> +Reference Counting
> +------------------
> +
> +Each shared devlink instance maintains a reference count (``refcount_t refcount``).
> +The reference count is incremented when ``devlink_shd_get()`` is called and
> +decremented when ``devlink_shd_put()`` is called. When the reference count

The file appears to be truncated here. The sentence ends mid-phrase with
"When the reference count" but should continue with something like
"reaches zero, the shared instance is automatically destroyed."

Comparing against the lore submission (V6), the original patch shows this
line should end with the complete sentence. Was this perhaps truncated
during commit application?

Simon says:

I looked into this and it seems that somehow the patch is slightly mangled.
The diff describes adding 94 lines as devlink-shared.rst.
But the contents has 95 lines.