From: Kory Maincent <kory.maincent@bootlin.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: Re: [PATCH net-next 01/13] net: phy: phy_port: Correctly recompute the port's linkmodes
Date: Tue, 27 Jan 2026 15:00:21 +0100 [thread overview]
Message-ID: <20260127150021.110a0ddc@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20260127134202.8208-2-maxime.chevallier@bootlin.com>
On Tue, 27 Jan 2026 14:41:49 +0100
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
> a PHY-driven phy_port contains a 'supported' field containing the
> linkmodes available on this port. This is populated based on :
> - The PHY's reported features
> - The DT representation of the connector
> - The PHY's attach_mdi() callback
>
> As these different attrbutin methods work in conjunction, the helper
Typo here: ^^^^^^^^^
> phy_port_update_supported() recomputes the final 'supported' value based
> on the populated mediums, linkmodes and pairs.
>
> However this recompute wasn't correctly implemented, and added more
> modes than necessary by or'ing the medium-specific modes to the existing
> support. Let's fix this and properly filter the modes.
>
> Fixes: 589e934d2735 ("net: phy: Introduce PHY ports representation")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
It is the only fix of the series, maybe you should send it standalone?
Else this seems ok to me.
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-01-27 14:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 13:41 [PATCH net-next 00/13] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 01/13] net: phy: phy_port: Correctly recompute the port's linkmodes Maxime Chevallier
2026-01-27 14:00 ` Kory Maincent [this message]
2026-01-27 15:21 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 02/13] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 03/13] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 04/13] net: phylink: Register a phy_port for MAC-driven SFP busses Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 05/13] net: phy: Create SFP phy_port before registering usptream Maxime Chevallier
2026-01-28 15:49 ` Romain Gantois
2026-01-30 13:31 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 06/13] net: sfp: Add a sfp-bus ops when connecting a module without PHY Maxime Chevallier
2026-01-30 16:19 ` Russell King (Oracle)
2026-01-30 17:08 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 07/13] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-01-28 15:54 ` Romain Gantois
2026-01-30 13:32 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 08/13] net: phylink: " Maxime Chevallier
2026-01-28 16:01 ` Romain Gantois
2026-01-30 13:36 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 09/13] net: phy: phy_port: Store information about a MII port's occupancy Maxime Chevallier
2026-01-28 16:08 ` Romain Gantois
2026-01-30 13:38 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 10/13] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-01-27 22:23 ` kernel test robot
2026-01-27 22:44 ` kernel test robot
2026-01-28 16:10 ` Romain Gantois
2026-01-30 13:41 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 11/13] net: phy: store phy_modes in a static array Maxime Chevallier
2026-01-27 13:42 ` [PATCH net-next 12/13] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-01-27 13:42 ` [PATCH net-next 13/13] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
2026-01-27 23:16 ` kernel test robot
2026-01-27 21:07 ` [PATCH net-next 00/13] net: phy_port: SFP modules representation and phy_port listing Jakub Kicinski
2026-01-27 21:18 ` Maxime Chevallier
2026-01-28 8:07 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127150021.110a0ddc@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox