From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9589425332E; Wed, 28 Jan 2026 02:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769569138; cv=none; b=ozFolpUaHpVeCxzPw+Bwp9Dixx3eH3wJ9CSkwUz8Xo3L6GpDUpkrbSIDvmj+5dPIj52mPsuLnz2JQPkdIkUsN8NTeRGYr4iZqg+YCBgSR4GZkERIj0Zm/rAeMaTwJaK3+s57yRIDMcIWlnXpLvPWpPrtrZmxdne4Op5MoinCfJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769569138; c=relaxed/simple; bh=Ac37IbqyWcca/4SCl1e9MinT7q6JQCs4TTXGSBDTQSM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gq/M7Mbv5DSY6kRBqzhRvKjMbVtXoE/WnpIov+2KKkG7elkSeM+UHQ1W0jmcJzfxj+3gfn8ll48XEzVjQqz37yt/xmf8p4OztSuvkTSIr+AJDBcndHJs8ddspEP00h9nk3heLhRIs6+Hr2kwQ2ZbUBkWYV7XqhdPvbwKDGCKh2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Czi83NqY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Czi83NqY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B749C116C6; Wed, 28 Jan 2026 02:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769569138; bh=Ac37IbqyWcca/4SCl1e9MinT7q6JQCs4TTXGSBDTQSM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Czi83NqYSNKrxmRgX372KLBq4N0q6ZYGNnWp0xDVFG4P7X8GrGke0CJ4zqsE8BxEN LDLPZY/w41T0q3kYeCNtejzOfiGaQ9Zadgsmxx5jVg6R5ufjKA/AMyL6j2zHFWpBtE cKgBDoV3wKRbB8PZUdjM7GwnByl8AifblS1CDl1P9NxJXJxM7yWqb3jXJsQ1fWjk0D 4TXdhbMv14oimt5km2iT5d6Lm7jecy0Jiscwm2IGAXtcCaXB5jflJUmA9llI8Cid+m sISGBjqanyJFIlpOGRBFDHhwLhw1fC31F01vo6Q0hDRSKngFZdqU/ZMp+PeRZC+JK3 yBy1gmfRyG+ag== Date: Tue, 27 Jan 2026 18:58:56 -0800 From: Jakub Kicinski To: Ethan Nelson-Moore Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andy Shevchenko , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Peter Korsgaard , Petko Manolov , Steve Glendinning , UNGLinuxDriver@microchip.com, Nikita Zhandarovich , Oliver Neukum , Krzysztof =?UTF-8?B?SGHFgmFzYQ==?= , Deepanshu Kartikey , Oleksij Rempel , Max Schulze , Thomas Gleixner , Ingo Molnar , "Gustavo A. R. Silva" , Kees Cook , Eric Biggers Subject: Re: [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo code and driver versions Message-ID: <20260127185856.7ff5d1a2@kernel.org> In-Reply-To: <20260127060534.51206-1-enelsonmoore@gmail.com> References: <20260127060534.51206-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Jan 2026 22:04:38 -0800 Ethan Nelson-Moore wrote: > Many USB network drivers define get_drvinfo functions which add no > value over usbnet_get_drvinfo, only setting the driver name and > version. usbnet_get_drvinfo automatically sets the driver name, and > separate driver versions are now frowned upon in the kernel. Remove all > driver versions and replace these get_drvinfo functions with references > to usbnet_get_drvinfo where possible. Where that is not possible, > remove unnecessary code to set the driver name. Also remove two > unnecessary initializations from aqc111_get_drvinfo, an inaccurate > comment in pegasus.c, and an unused macro in catc.c. I slightly lost track of the conversations on your patches so forgive a possibly obvious statement :) - but this did not apply cleanly to net-next at the time of posting. So it needs a respin. -- pw-bot: cr